Microversion 2.37 break 2.32 usage

Bug #1658571 reported by Zhenyu Zheng
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Artom Lifshitz
python-novaclient
Fix Released
Undecided
Matt Riedemann

Bug Description

Device tagging support was added in microversion 2.32, as for
ports:
http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n76
but in latter microversion 2.37 accidentally removed it:
http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n82

And for bdms:
the schema is added by
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/block_device_mapping.py#L76
and it will only work for microversion 2.32

So this function is only usable from microversion 2.32 to 2.37 for
ports and only for 2.32 for bdms.

we should fix it and backport to Newton.

Tags: api
Changed in nova:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
Revision history for this message
Ghanshyam Mann (ghanshyammann) wrote :

Yea, it somehow overridden the tag filed.

tags: added: newton-backport-potential
Alex Xu (xuhj)
Changed in nova:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/423952

Changed in nova:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/424759

Changed in nova:
assignee: Zhenyu Zheng (zhengzhenyu) → Artom Lifshitz (notartom)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/425876

Matt Riedemann (mriedem)
tags: added: ocata-rc-potential
removed: newton-backport-potential
Changed in nova:
assignee: Artom Lifshitz (notartom) → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/423952
Reason: Let's go with this:

https://review.openstack.org/#/c/424759/

Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Artom Lifshitz (notartom)
Revision history for this message
Matt Riedemann (mriedem) wrote :

https://review.openstack.org/#/c/424745/ is the related novaclient patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/424759
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e80e2511cf825671a479053cc8d41463aab1caaa
Submitter: Jenkins
Branch: master

commit e80e2511cf825671a479053cc8d41463aab1caaa
Author: Artom Lifshitz <email address hidden>
Date: Tue Jan 24 12:27:15 2017 -0500

    Fix tag attribute disappearing in 2.33 and 2.37

    In the context of device tagging, bugs have caused the tag attribute
    to disappear starting with version 2.33 for block_devices and starting
    with version 2.37 for network interfaces. In other words, block
    devices could only be tagged in 2.32 and network interfaces between
    2.32 and 2.36 inclusively.

    This patch documents this behaviour in api-ref and introduces
    microversion 2.42, which re-adds the tag in all the right places.

    Change-Id: Ia0869dc6f7f5bd347ccbd0930d1d668d37695a22
    Closes-bug: 1658571
    Implements: blueprint fix-tag-attribute-disappearing

Changed in nova:
status: In Progress → Fix Released
Matt Riedemann (mriedem)
tags: added: api
removed: ocata-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.0.0rc1

This issue was fixed in the openstack/nova 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/430352

Changed in python-novaclient:
assignee: nobody → Takashi NATSUME (natsume-takashi)
status: New → In Progress
Changed in python-novaclient:
assignee: Takashi NATSUME (natsume-takashi) → Matt Riedemann (mriedem)
Changed in python-novaclient:
assignee: Matt Riedemann (mriedem) → Takashi NATSUME (natsume-takashi)
Changed in python-novaclient:
assignee: Takashi NATSUME (natsume-takashi) → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-novaclient (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/424745
Reason: Fixed in https://review.openstack.org/#/c/429512/.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 9.0.0

This issue was fixed in the openstack/python-novaclient 9.0.0 release.

Revision history for this message
Takashi Natsume (natsume-takashi) wrote :

The bug in python-novaclient has been fixed in the following patch.

https://review.openstack.org/#/c/429512/

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Artom Lifshitz (<email address hidden>) on branch: master
Review: https://review.openstack.org/430352
Reason: There's obviously no interest, and I don't have the energy to create any. Abandonning.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Artom Lifshitz (<email address hidden>) on branch: master
Review: https://review.openstack.org/425876
Reason: Doesn't look like there's much interest, abandoning.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints