_process_instance_vif_deleted_event fails with "TypeError: detach_interface() takes exactly 4 arguments (3 given)"

[Matt Riedemann]

Seeing this in a gate job here:

http://logs.openstack.org/00/398800/1/gate/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/a387fb0/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-11-17_11_29_10_965

2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server [req-1e141c4e-e2eb-4b06-89b5-849ecf4d065d nova service] Exception during message handling
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 155, in _process_incoming
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 225, in dispatch
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 195, in _do_dispatch
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/opt/stack/new/nova/nova/exception_wrapper.py", line 75, in wrapped
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server function_name, call_dict, binary)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server self.force_reraise()
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/opt/stack/new/nova/nova/exception_wrapper.py", line 66, in wrapped
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server return f(self, context, *args, **kw)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/opt/stack/new/nova/nova/compute/manager.py", line 6755, in external_instance_event
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server event.tag)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server File "/opt/stack/new/nova/nova/compute/manager.py", line 6724, in _process_instance_vif_deleted_event
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server self.driver.detach_interface(instance, vif)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server TypeError: detach_interface() takes exactly 4 arguments (3 given)
2016-11-17 11:29:10.965 2249 ERROR oslo_messaging.rpc.server

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22_process_instance_vif_deleted_event%5C%22%20AND%20message%3A%5C%22TypeError%3A%20detach_interface()%20takes%20exactly%204%20arguments%20(3%20given)%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d

New regression as of 11/16: https://review.openstack.org/#/c/209362/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/399155

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399155
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=383e795a5ed16cdafdab04858c1bd889fa893fe5
Submitter: Jenkins
Branch: master

commit 383e795a5ed16cdafdab04858c1bd889fa893fe5
Author: Dan Smith <email address hidden>
Date: Thu Nov 17 09:59:32 2016 -0800

    Fix detach_interface() call from external event handler

    The signature for VirtDriver.detach_interface() changed recently in
    41591c9456fd4eb91407551b9b9898e8f4974050, but the call from the
    external event handler was not updated. This does that.

    Change-Id: I560920ed521f09909d91bb0aac42bf97447475b0
    Closes-Bug: #1642681

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b2 development milestone.