fixed_ips missing from compute.update.end notifications

[Steve McLellan]

This is part of a series of reports around discrepancies between the nova servers API response and notification payloads as affects Searchlight; see https://bugs.launchpad.net/nova/+bug/1637634 for background.

An example API response to retrieve a server's information is at http://paste.openstack.org/show/xbv2CwtHnhhl1nLLiJeN/

An example compute.create.end notification is at http://paste.openstack.org/show/zG5aJeUpC3LAGr0J0P2T/

An example compute.update.end notification is at http://paste.openstack.org/show/uwh1izVsaW5eg7zDrgFm/

fixed_ips is present in compute.create.end notifications and contains IP/MAC/network information related to neutron ports added during instance creation. This field is missing from compute.update.end notification payloads, and this causes us a problem because it's much better from Searchlight's perspective if notification payloads are consistent and complete representations of a resource's state.

Searchlight currently has an optimization to detect whether compute.update.end notifications represent scheduler state changes like suspending, resuming, etc, and for those does a partial update. For other events it currently has to go the nova API to get the current representation of the affected server.

[Balazs Gibizer (balazs-gibizer)]

The versioned instance.create.end and instance.update notification have the same payload base class which contains an ip_addresses field [1] that holds [2] the necessary information.

[1]https://github.com/openstack/nova/blob/master/nova/notifications/objects/instance.py#L81
[2]https://github.com/openstack/nova/blob/master/nova/notifications/objects/instance.py#L154

Based on this I think this problem is already solved during the versioned notification transformation.

[Steve McLellan (sjmc7)]

Excellent! We'll check out the versioned notifications and confirm.