nova's osapi_compute_workers is not valid (must be greater than 1)

[Dan Prince]

As of Nova e8436283e45b6716fb61d6f6590fadb5fb4ba45c commit TripleO now fails to deploy nova-api correctly. This is because our default value set osapi_compute_workers=0 and metadata_workers=0 and this is no longer valid. Nova now requires an integer greater than 0, or an empty string.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/383440

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/385058

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/385078

[Dan Prince (dan-prince)]

Fixed in: https://review.openstack.org/#/c/385078/ (Only set NovaWorkers in the non-default case)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/383478
Reason: https://review.openstack.org/#/c/385078/ is better

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385058
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a80d13b6e168c59d9860898063cf2c7067a65532
Submitter: Jenkins
Branch: master

commit a80d13b6e168c59d9860898063cf2c7067a65532
Author: Dan Prince <email address hidden>
Date: Tue Oct 11 11:38:38 2016 -0400

    Remove duplicate metadata keys from nova-api.yaml

    These keys are already specified in nova-metadata.yaml
    where they get set correctly per the network management
    local IP (based on 'service_name' list).

    Depends-On: I94f985e719a3bf7408655fbbb5ab1aeaf15e994e

    Change-Id: I5d57561b732783118efd2a637aa137f5f7bcddbc
    Partial-bug: #1631133

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385078
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=38f98383d396d89b8f6047e57e5e606615ee5a16
Submitter: Jenkins
Branch: master

commit 38f98383d396d89b8f6047e57e5e606615ee5a16
Author: Dan Prince <email address hidden>
Date: Tue Oct 11 12:09:43 2016 -0400

    Only set NovaWorkers in the non-default case

    This patch updates the t-h-t templates for
    nova services so that we only set the value of workers in
    the non-default case. TripleO has always defaulted the
    workers count to 0 and there was recently a regression in
    nova where they treat the default of 0 as invalid (a bug
    that may get fixed in nova but we don't want to wait on it)

    This patch avoids the issue by allowing the default value
    to be unset if the TripleO default of 0 is configured.

    Change-Id: I175977b88129d87caeb32332d47eb14816a6d5d4
    Closes-bug: #1631133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/393327

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/393327
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9f4f57b61aca560dee4a4f3af98b8c127e08e0d3
Submitter: Jenkins
Branch: stable/newton

commit 9f4f57b61aca560dee4a4f3af98b8c127e08e0d3
Author: Dan Prince <email address hidden>
Date: Tue Oct 11 11:38:38 2016 -0400

    Remove duplicate metadata keys from nova-api.yaml

    These keys are already specified in nova-metadata.yaml
    where they get set correctly per the network management
    local IP (based on 'service_name' list).

    Conflicts:
     puppet/services/nova-api.yaml

    Depends-On: I94f985e719a3bf7408655fbbb5ab1aeaf15e994e

    Change-Id: I5d57561b732783118efd2a637aa137f5f7bcddbc
    Partial-bug: #1631133
    (cherry picked from commit a80d13b6e168c59d9860898063cf2c7067a65532)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dan Prince (<email address hidden>) on branch: master
Review: https://review.openstack.org/383440

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.