Policy config is misplaced

Bug #1625644 reported by Maciej Szankin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Low
Unassigned

Bug Description

Patch 9864801d468de5dde79141cbab4374bd2310bef2 introduced config options that are registered outside nova/conf/ directory, thus violating check N342 (which does not work, it will be fixed in https://review.openstack.org/#/c/355597/ which cannot be introduced until the issue with policy configs is fixed).

Logs:
2016-09-14 08:33:33.496626 | ./nova/cmd/policy_check.py:39:1: N342 Config options should be in the central location '/nova/conf/*'. Do not declare new config options outside of that folder.
2016-09-14 08:33:33.496779 | ./nova/cmd/policy_check.py:148:1: N342 Config options should be in the central location '/nova/conf/*'. Do not declare new config options outside of that folder.

Changed in nova:
assignee: nobody → Maciej Szankin (mszankin)
Revision history for this message
Matt Riedemann (mriedem) wrote :

I think this could be resolved by fixing bug 1619382 instead - the options in the policy_check command are CLI options which makes them a bit different. I'm not really sure what value is in using CLI options, but I'd expect to just handle those options like normal CLI options, i.e. argparse options.

Changed in nova:
status: New → Confirmed
Revision history for this message
Matt Riedemann (mriedem) wrote :

At a minimum we should loosen up the hacking check to allow CLI options to be defined outside of nova/conf/.

Changed in nova:
importance: Undecided → Low
Sean Dague (sdague)
Changed in nova:
assignee: Maciej Szankin (mszankin) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.