remove_deleted_instances in RT stacktraces with AttributeError

[Matt Riedemann]

http://logs.openstack.org/92/371092/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/62ba450/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-09-15_21_07_36_354

2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager [req-a2ce4588-a9b5-466d-9f06-62d78a23fd04 - -] Error updating resources for node ubuntu-xenial-osic-cloud1-4322012.
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager Traceback (most recent call last):
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/compute/manager.py", line 6416, in update_available_resource_for_node
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager rt.update_available_resource(context)
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 526, in update_available_resource
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager self._update_available_resource(context, resources)
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager return f(*args, **kwargs)
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 562, in _update_available_resource
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager self._update_usage_from_instances(context, instances)
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 903, in _update_usage_from_instances
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager self.compute_node, self.tracked_instances.values())
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/scheduler/client/__init__.py", line 37, in __run_method
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager return getattr(self.instance, __name)(*args, **kwargs)
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/scheduler/client/report.py", line 446, in remove_deleted_instances
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager for instance in instance_uuids}
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager File "/opt/stack/new/nova/nova/scheduler/client/report.py", line 446, in <dictcomp>
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager for instance in instance_uuids}
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager AttributeError: 'dict' object has no attribute 'uuid'
2016-09-15 21:07:36.354 15826 ERROR nova.compute.manager

Introduced with: https://review.openstack.org/#/c/369147/

[Matt Riedemann (mriedem)]

Let's target this for rc2.

[melanie witt (melwitt)]

Patch is up at: https://review.openstack.org/#/c/371179/

Closes-Bug was on PS1 and it still didn't link it for some reason.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371179
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=30a85c8bcfb9ba7a66364df7eb1dc3dfc61341ab
Submitter: Jenkins
Branch: master

commit 30a85c8bcfb9ba7a66364df7eb1dc3dfc61341ab
Author: Dan Smith <email address hidden>
Date: Thu Sep 15 15:07:32 2016 -0700

    Fix object assumption in remove_deleted_instances()

    The RT tracks instance dicts for some reason. Fix that and make the
    test poke the previous issue.

    Change-Id: Iae3b2aa8e655f51f6fffd98dd02fa8e1cd9366c3
    Closes-Bug: #1624119

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.