placement-api http responses are not marked for translation

Bug #1621888 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Dent

Bug Description

The HTTP error responses from the placement-api should be marked for translation with _(), like here:

https://github.com/openstack/nova/blob/f441ee55c6f99a099fe1a68a6cfa486fd522554f/nova/api/openstack/placement/handlers/allocation.py#L101

            raise webob.exc.HTTPBadRequest(
                "Allocation for resource provider '%s' "
                "that does not exist." % resource_provider_uuid,
                json_formatter=util.json_error_formatter)

Tags: i18n placement
Matt Riedemann (mriedem)
tags: added: i18n placement
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Chris Dent (cdent)
Changed in nova:
assignee: nobody → Chris Dent (cdent)
Revision history for this message
Chris Dent (cdent) wrote :

I'll do this, but I'm going to wait for some of the api changes that are in progress to land so I can do it all in one go.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Let's fix this now and get marked what already exists in the code as of today. RC1 for newton is Thursday so I don't really want to wait for other things.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/369035

Matt Riedemann (mriedem)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/369035
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a4b5b0c859a6e194987652708b5473827a1cd604
Submitter: Jenkins
Branch: master

commit a4b5b0c859a6e194987652708b5473827a1cd604
Author: Chris Dent <email address hidden>
Date: Mon Sep 12 20:00:08 2016 +0000

    [placement] Mark HTTP error responses for translation

    The HTTP responses that are errors and provided messages to the
    client should be marked for translation. This change does that.

    Change-Id: If22270768c2e6cdb810e0e08b3a4ab7a42bf828d
    Closes-Bug: #1621888

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 14.0.0.0rc1

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.