architecture not validated in "openstack image create"

[Gaby Beitler]

On Liberty

<error> <mistyped architecture, but is accepted anyway>

$ openstack image create \
  --public \
  --container-format bare \
  --disk-format qcow2 \
  --min-disk 2 --min-ram 512 \
  --file /home/images/SLES12SP1-cloudimage.qcow2 \
  SLES12SP1-x86_64
+------------------+------------------------------------------------------+
| Field | Value |
+------------------+------------------------------------------------------+
| checksum | fcdeb8b10730ac96bccc9a121ee030f4 |
| container_format | bare |
| created_at | 2016-08-02T20:51:45Z |
| disk_format | qcow2 |
| file | /v2/images/e7f289aa-e689-4f0a-a0a0-43f341986fd5/file |
| id | e7f289aa-e689-4f0a-a0a0-43f341986fd5 |
| min_disk | 2 |
| min_ram | 512 |
| name | SLES12SP1-x86_64 |
| owner | f7ed231f244b4b2db8b1e580f36e1580 |
| protected | False |
| schema | /v2/schemas/image |
| size | 362847744 |
| status | active |
| updated_at | 2016-08-02T20:51:51Z |
| virtual_size | None |
| visibility | public |
+------------------+------------------------------------------------------+

# openstack image set \
  --name SLES12-SP1 \
  --architecture x96_64 \
  --os-distro sles \ # <-- the problem
  --os-version 12.1 \
  SLES12SP1-x86_64
+------------------+------------------------------------------------------+
| Field | Value |
+------------------+------------------------------------------------------+
| architecture | x96_64 |
| checksum | fcdeb8b10730ac96bccc9a121ee030f4 |
| container_format | bare |
| created_at | 2016-08-02T20:51:45Z |
| disk_format | qcow2 |
| file | /v2/images/e7f289aa-e689-4f0a-a0a0-43f341986fd5/file |
| id | e7f289aa-e689-4f0a-a0a0-43f341986fd5 |
| min_disk | 2 |
| min_ram | 512 |
| name | SLES12-SP1 |
| os_distro | sles |
| os_version | 12.1 |
| owner | f7ed231f244b4b2db8b1e580f36e1580 |
| protected | False |
| schema | /v2/schemas/image |
| size | 362847744 |
| status | active |
| tags | [] |
| updated_at | 2016-08-02T20:53:00Z |
| virtual_size | None |
| visibility | public |
+------------------+------------------------------------------------------+

$ openstack server create \
  --flavor m1.smaller \
  --image SLES12-SP1 \
  vm01
Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.
<type 'exceptions.ValueError'> (HTTP 500) (Request-ID: req-5fc1ad67-86ad-4a69-b7f4-905861a8f2fc)

********
<Success> <Change architecture from x96_64 to x86_64>

# openstack image set \
  --name SLES12-SP1 \
  --architecture x86_64 \
  --os-distro sles \
  --os-version 12.1 \
  SLES12-SP1
+------------------+------------------------------------------------------+
| Field | Value |
+------------------+------------------------------------------------------+
| architecture | x86_64 |
| checksum | fcdeb8b10730ac96bccc9a121ee030f4 |
| container_format | bare |
| created_at | 2016-08-02T20:51:45Z |
| disk_format | qcow2 |
| file | /v2/images/e7f289aa-e689-4f0a-a0a0-43f341986fd5/file |
| id | e7f289aa-e689-4f0a-a0a0-43f341986fd5 |
| min_disk | 2 |
| min_ram | 512 |
| name | SLES12-SP1 |
| os_distro | sles |
| os_version | 12.1 |
| owner | f7ed231f244b4b2db8b1e580f36e1580 |
| protected | False |
| schema | /v2/schemas/image |
| size | 362847744 |
| status | active |
| tags | [] |
| updated_at | 2016-08-02T20:55:55Z |
| virtual_size | None |
| visibility | public |
+------------------+------------------------------------------------------+

# openstack server create \
  --flavor m1.smaller
  --image SLES12-SP1 vm01
+--------------------------------------+---------------------------------------------------+
| Field | Value |
+--------------------------------------+---------------------------------------------------+
| OS-DCF:diskConfig | MANUAL |
| OS-EXT-AZ:availability_zone | |
| OS-EXT-SRV-ATTR:host | None |
| OS-EXT-SRV-ATTR:hypervisor_hostname | None |
| OS-EXT-SRV-ATTR:instance_name | instance-00000012 |
| OS-EXT-STS:power_state | 0 |
| OS-EXT-STS:task_state | scheduling |
| OS-EXT-STS:vm_state | building |
| OS-SRV-USG:launched_at | None |
| OS-SRV-USG:terminated_at | None |
| accessIPv4 | |
| accessIPv6 | |
| addresses | |
| adminPass | B8U3uzDDMre9 |
| config_drive | |
| created | 2016-08-02T20:56:04Z |
| flavor | m1.smaller (6afe7481-51e0-4a47-8934-0c2fee314fc5) |
| hostId | |
| id | 12dc8a78-51c3-419a-a484-d604efc0f4d8 |
| image | SLES12-SP1 (e7f289aa-e689-4f0a-a0a0-43f341986fd5) |
| key_name | None |
| name | vm01 |
| os-extended-volumes:volumes_attached | [] |
| progress | 0 |
| project_id | f7ed231f244b4b2db8b1e580f36e1580 |
| properties | |
| security_groups | [{u'name': u'default'}] |
| status | BUILD |
| updated | 2016-08-02T20:56:04Z |
| user_id | 940803780c224ee780656630134320fc |
+--------------------------------------+---------------------------------------------------+

# openstack server list
+--------------------------------------+------+--------+----------------------+
| ID | Name | Status | Networks |
+--------------------------------------+------+--------+----------------------+
| 12dc8a78-51c3-419a-a484-d604efc0f4d8 | vm01 | ACTIVE | fixed=192.168.123.15 |
+--------------------------------------+------+--------+----------------------+

[tamil vanan (tamilhce)]

reproduced the issue, working on the code fix

[tamil vanan (tamilhce)]

Have submitted the code patch, Not accepted in code review, Need to follow up with glance team

[tamil vanan (tamilhce)]

https://review.openstack.org/#/c/362861/

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[Sean Dague (sdague)]

Automatically discovered version liberty in description. If this is incorrect, please update the description to include 'nova version: ...'

[Stephen Finucane (stephenfinucane)]

This bug should be filed against glance, rather than nova. From what I can tell, glance provides a config option to allow users to opt-in to only allowing valid image metadata properties.