limits API isn't filtering security groups and floating IPs from 2.36 response

[Matt Riedemann]

The limits API isn't filtering out network resources like security groups and floating IPs from the 2.36 response (like it does for quota sets):

https://github.com/openstack/nova/blob/955c921b33103e6e03a665f1e7bf705f5c661c68/nova/api/openstack/compute/used_limits.py#L44

I found this when testing some changes in novaclient for 2.36.

DEBUG (session:337) REQ: curl -g -i -X GET http://9.5.125.222:8774/v2.1/limits -H "OpenStack-API-Version: compute 2.36" -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-OpenStack-Nova-API-Version: 2.36" -H "X-Auth-Token: {SHA1}eeec7f2d075d62c93954f4f0619d78ac07017379"
DEBUG (connectionpool:401) "GET /v2.1/limits HTTP/1.1" 200 430
DEBUG (session:366) RESP: [200] Content-Length: 430 Content-Type: application/json Openstack-Api-Version: compute 2.36 X-Openstack-Nova-Api-Version: 2.36 Vary: OpenStack-API-Version, X-OpenStack-Nova-API-Version X-Compute-Request-Id: req-189b16e7-fabb-4f5a-a0ab-e9c90ede95a7 Date: Wed, 17 Aug 2016 14:51:45 GMT Connection: keep-alive
RESP BODY: {"limits": {"rate": [], "absolute": {"maxServerMeta": 128, "maxPersonality": 5, "totalServerGroupsUsed": 0, "maxImageMeta": 128, "maxPersonalitySize": 10240, "maxTotalKeypairs": 100, "totalCoresUsed": 0, "maxServerGroups": 10, "totalRAMUsed": 0, "totalInstancesUsed": 0, "totalFloatingIpsUsed": 0, "maxTotalCores": 20, "maxServerGroupMembers": 10, "totalSecurityGroupsUsed": 0, "maxTotalInstances": 10, "maxTotalRAMSize": 51200}}}

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/356694
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4461cdf4c464ecf54444c8d86544453f30de1fd4
Submitter: Jenkins
Branch: master

commit 4461cdf4c464ecf54444c8d86544453f30de1fd4
Author: Sean Dague <email address hidden>
Date: Wed Aug 17 16:20:45 2016 -0400

    don't report network limits after 2.35

    We correctly stopped reporting the limits for things like security
    groups and floating ips after mv 2.35. We completely missed that
    limits are modified by the used_limits extension, and hilarity
    ensued. We were reporting no maxSecurityGroups over the wire, but we
    were reporting totalSecurityGroups through the magic of extensions.

    Change-Id: I85b2b41d919ed6987d4c9288905ccce49c10c81f
    Closes-Bug: #1614133

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0b3 development milestone.