Improve error log when instance snapshot fails

[vu tran]

If glance backend store is set to use filesystem storage and this storage is running out of space when if glance is trying to create a instance snapshot, then in nova-compute log the following message is displayed:

2016-08-08 22:24:31.644 TRACE oslo_messaging.rpc.server HTTPOverLimit: 413 Request Entity Too Large
2016-08-08 22:24:31.644 TRACE oslo_messaging.rpc.server Image storage media is full: There is not enough disk space on the image storage media.
2016-08-08 22:24:31.644 TRACE oslo_messaging.rpc.server (HTTP 413)

It's a little bit annoying that we're logging the HTTP error from glance and that we don't specify the image uuid.

Steps to reproduce:
* set glance's config filesystem_store_datadir to small size filesystem
* start nova instance
* keep invoking "nova image-create" to create instance image snapshot, eventually the backend filesystem storage would run out of space
* on nova-compute log see the HTTP error message above.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[Sean Dague (sdague)]

Found open reviews for this bug in gerrit, setting to In Progress.

review: https://review.openstack.org/356020 in branch: master

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/356020
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=024bf10d8aec5e58111793a9652b16682eb61b7c
Submitter: Zuul
Branch: master

commit 024bf10d8aec5e58111793a9652b16682eb61b7c
Author: Vu Tran <email address hidden>
Date: Mon Aug 29 16:33:19 2016 -0400

    Improve error log when snapshot fails

    If snapshot creation via glance fails due to lack of space or over
    quota, we want to have a clearer error message.

    Change-Id: Ic9133f6bc14d4fe766d37a438bf52c33e89da768
    Closes-Bug: #1613770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/782982
Committed: https://opendev.org/openstack/nova/commit/9e9c022bde3a3ffdf0dd87e21bf9afde0dbc1e74
Submitter: "Zuul (22348)"
Branch: stable/train

commit 9e9c022bde3a3ffdf0dd87e21bf9afde0dbc1e74
Author: Vu Tran <email address hidden>
Date: Mon Aug 29 16:33:19 2016 -0400

    Improve error log when snapshot fails

    If snapshot creation via glance fails due to lack of space or over
    quota, we want to have a clearer error message.

    Change-Id: Ic9133f6bc14d4fe766d37a438bf52c33e89da768
    Closes-Bug: #1613770
    (cherry picked from commit 024bf10d8aec5e58111793a9652b16682eb61b7c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.6.1 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/782962
Committed: https://opendev.org/openstack/nova/commit/446c9c56109329208193e3c9b106a0a2eb3cd9ce
Submitter: "Zuul (22348)"
Branch: stable/stein

commit 446c9c56109329208193e3c9b106a0a2eb3cd9ce
Author: Vu Tran <email address hidden>
Date: Mon Aug 29 16:33:19 2016 -0400

    Improve error log when snapshot fails

    If snapshot creation via glance fails due to lack of space or over
    quota, we want to have a clearer error message.

    Change-Id: Ic9133f6bc14d4fe766d37a438bf52c33e89da768
    Closes-Bug: #1613770
    (cherry picked from commit 024bf10d8aec5e58111793a9652b16682eb61b7c)
    (cherry picked from commit 9e9c022bde3a3ffdf0dd87e21bf9afde0dbc1e74)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/nova/+/782984
Reason: This branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova stein-eol release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/rocky
Review: https://review.opendev.org/c/openstack/nova/+/782983
Reason: This branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.