vif_port_id of ironic port is not updated after neutron port-delete

[Andrey Shestakov]

Steps to reproduce
==================
1. Get list of attached ports of instance:
nova interface-list 42dd8b8b-b2bc-420e-96b6-958e9295b2d4
+------------+--------------------------------------+--------------------------------------+-----------------------------------------------+-------------------+
| Port State | Port ID | Net ID | IP addresses | MAC Addr |
+------------+--------------------------------------+--------------------------------------+-----------------------------------------------+-------------------+
| ACTIVE | 512e6c8e-3829-4bbd-8731-c03e5d7f7639 | ccd0fd43-9cc3-4544-b17c-dfacd8fa4d14 | 10.1.0.6,fdea:fd32:11ff:0:f816:3eff:fed1:8a7c | 52:54:00:85:19:89 |
+------------+--------------------------------------+--------------------------------------+-----------------------------------------------+-------------------+
2. Show ironic port. it has vif_port_id in extra with id of neutron port:
ironic port-show 735fcaf5-145d-4125-8701-365c58c6b796
+-----------------------+-----------------------------------------------------------+
| Property | Value |
+-----------------------+-----------------------------------------------------------+
| address | 52:54:00:85:19:89 |
| created_at | 2016-07-20T13:15:23+00:00 |
| extra | {u'vif_port_id': u'512e6c8e-3829-4bbd-8731-c03e5d7f7639'} |
| local_link_connection | |
| node_uuid | 679fa8a9-066e-4166-ac1e-6e77af83e741 |
| pxe_enabled | |
| updated_at | 2016-07-22T13:31:29+00:00 |
| uuid | 735fcaf5-145d-4125-8701-365c58c6b796 |
+-----------------------+-----------------------------------------------------------+
3. Delete neutron port:
neutron port-delete 512e6c8e-3829-4bbd-8731-c03e5d7f7639
Deleted port: 512e6c8e-3829-4bbd-8731-c03e5d7f7639
4. It is gone from interface list:
nova interface-list 42dd8b8b-b2bc-420e-96b6-958e9295b2d4
+------------+---------+--------+--------------+----------+
| Port State | Port ID | Net ID | IP addresses | MAC Addr |
+------------+---------+--------+--------------+----------+
+------------+---------+--------+--------------+----------+
5. ironic port still has vif_port_id with neutron's port id:
ironic port-show 735fcaf5-145d-4125-8701-365c58c6b796
+-----------------------+-----------------------------------------------------------+
| Property | Value |
+-----------------------+-----------------------------------------------------------+
| address | 52:54:00:85:19:89 |
| created_at | 2016-07-20T13:15:23+00:00 |
| extra | {u'vif_port_id': u'512e6c8e-3829-4bbd-8731-c03e5d7f7639'} |
| local_link_connection | |
| node_uuid | 679fa8a9-066e-4166-ac1e-6e77af83e741 |
| pxe_enabled | |
| updated_at | 2016-07-22T13:31:29+00:00 |
| uuid | 735fcaf5-145d-4125-8701-365c58c6b796 |
+-----------------------+-----------------------------------------------------------+

Expected result
===============
ironic port should not have vif_port_id in extra field.

Actual result
=============
ironic port has vif_port_id with id of deleted neutron port.

This can confuse when user wants to get list of unused ports of ironic node.
vif_port_id should be removed after neutron port-delete.
Corresponding bug filed on neutron side https://bugs.launchpad.net/neutron/+bug/1606229

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/347410
Reason: This review is > 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[Sean Dague (sdague)]

This is an old enough bug, is this still an issue?

[Launchpad Janitor (janitor)]

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]