test_neutronv2 unit tests fail with python-neutronclient 5.0.0
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Matt Riedemann |
Bug Description
Seen in a g-r change here:
https:/
2016-07-30 17:59:01.388984 | Captured traceback:
2016-07-30 17:59:01.389033 | ~~~~~~~~~~~~~~~~~~~
2016-07-30 17:59:01.389058 | Traceback (most recent call last):
2016-07-30 17:59:01.389095 | File "nova/tests/
2016-07-30 17:59:01.389120 | tenant_
2016-07-30 17:59:01.389175 | File "/home/
2016-07-30 17:59:01.389200 | self._checker.
2016-07-30 17:59:01.389253 | File "/home/
2016-07-30 17:59:01.389280 | % (' '.join(
2016-07-30 17:59:01.389311 | AttributeError: No values given for arguments: project_id
It's because of this change: https:/
And these unit tests are creating a mox'ed mock of the neutronclient Client class, which doesn't get that these methods are decorated with a rename from debtcollector:
http://
We currently require neutronclient>=4.2 which doesn't have these kwargs, so I can't start passing project_
We might have to change the tests to use mock instead of mox which is less strict.
Changed in nova: | |
assignee: | nobody → Matt Riedemann (mriedem) |
status: | Triaged → In Progress |
I tried stubbing out the mox'ed neutronclient in the tests but it's not happy about that - the stub doesn't work for the asserts:
http:// paste.openstack .org/show/ 544710/