ImageRef for server create/rebuild/rescue etc are accepted as random url

[Ghanshyam Mann]

Currently imageRef in server create, rebuild and rescue
operation can be accepted as random url which contains image
UUID and fetch the UUID from that.

ImageRef in server creation etc are UUID only and valid against glance.

Currently nova used to fetch the UUID from ImageRef url and proceed.

As /images proxy APIs are deprecated, it make sense to strict
the imageRef to UUID only and return 400 when non UUID(random url) is requested.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338802
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cbd3ec476f769c42e5b2a0ef8c996b60935e7f6c
Submitter: Jenkins
Branch: master

commit cbd3ec476f769c42e5b2a0ef8c996b60935e7f6c
Author: ghanshyam <email address hidden>
Date: Thu Jul 28 16:11:47 2016 +0900

    Strict ImageRef validation to UUID only

    Currently imageRef in server create, rebuild and rescue
    operation can be accepted as random url which contains image
    UUID and fetch the UUID from that.

    As /images proxy APIs are deprecated, and ImageRef in
    server creation etc are UUID only and valid against glance.

    This patch makes imageRef handling as UUID only and
    return 400 if non UUID are requested.

    NOTE- Previously nova use to allow the empty string which was
          ok in case of boot from volume.
          We will keep the same behavior of allowing empty string in case of
          boot from volume only and 400 in all other case.

    Closes-Bug: #1607229

    Change-Id: I49f4da62c1b5b3fd8c5f67039ae113f76722b26c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0b3 development milestone.