os-quota-class-sets APIs are undocumented

[Matthew Edmonds]

http://developer.openstack.org/api-ref does not document the os-quota-class-sets APIs for either nova or cinder.

[Matt Riedemann (mriedem)]

quota classes are an old concept that was pluggable for out of tree quota classes, I think rackspace had some plugins for that. In tree we only have the 'default' quota class. Probably just something to keep in mind when documenting this.

[Matt Riedemann (mriedem)]

There are also only 3 actions for os-quota-class-sets, create, update and show, there is no delete. And the update/create are munged together, the API tries to update and if we get a not found from the database on that class set we do a create.

[Matt Riedemann (mriedem)]

Also: http://lists.openstack.org/pipermail/openstack-dev/2016-July/099218.html

[Matt Riedemann (mriedem)]

FYI: https://blueprints.launchpad.net/nova/+spec/only-default-quota-class

[Matt Riedemann (mriedem)]

If we document this in the API, we should really tell people to not use it, because it's a mess.

Basically there are no quota_classes in the database to start with. Quota values come from the defaults in nova.conf. However, if you update the quotas for the "default" quota class, then those are stuck in the database and preferred over the config options *AND* it's global, not per-tenant.

So if you updated default quotas for let's say instances, to 20, but didn't change quota_instances in your nova.conf, you'd still have a default quota for instances at 20 for all projects.

If you then change quota_instances=5 in nova.conf, but didn't update the 'default' quota class via the API, you'll still have a default quota of 20 for instances regardless of nova.conf.

[Matt Riedemann (mriedem)]

Related spec: https://review.openstack.org/#/c/411035/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/467938

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/477740

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467938
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b25b66e284dfae5afcbb1502abf27f013447f470
Submitter: Jenkins
Branch: master

commit b25b66e284dfae5afcbb1502abf27f013447f470
Author: ghanshyam <email address hidden>
Date: Thu May 25 12:06:11 2017 +0300

    Add api-ref for os-quota-class-set APIs

    This commit adds the api doc for os-quota-class-set GET & PUT
    APIs.

    - Also mentioned about the recommendation over usage of this API.
    - Added warning for current bug in v2.1 API #1693168

    This is also needed by BP
    - https://blueprints.launchpad.net/nova/+spec/fix-quota-classes-api

    Change-Id: Ib765e2d1dec7b236a2009148e0b1067a46326ce9
    Related-Bug: #1693168
    Closes-Bug: #1602400

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/477740
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6932f2a84171a44b29482cd3d5e93629e8e869d8
Submitter: Jenkins
Branch: master

commit 6932f2a84171a44b29482cd3d5e93629e8e869d8
Author: Felipe Monteiro <email address hidden>
Date: Tue Jun 27 05:22:00 2017 +0100

    [api-ref] Add api-ref for os-quota-class-sets APIs

    This commit adds the api documentation for the
    GET/PUT os-quota-class-set APIs (v2 and v3).

    Change-Id: Idb51b7b90a081775d2d836bf6d9ec8b9c0399f1b
    Closes-Bug: #1602400

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0rc1 release candidate.