Incorrect cellid in NUMA memnode

[Rafael Folco]

Description
===========

Nova generating wrong cellid for numa memnode.

Some systems number nodeset for the NUMA topology in non-sequential way, as follows:

node 0 1 16 17

Steps to reproduce
==================
Create a flavor w/ hw:numa_nodes=4 (hw:cpu_policy unset)

Spawn an instance across multiple nodes

Check nodeset in the instance XML

Expected result
===============

Correct cellid:

    <memnode cellid='0' mode='strict' nodeset='0'/>

    <memnode cellid='1' mode='strict' nodeset='1'/>

    <memnode cellid='2' mode='strict' nodeset='16'/>

    <memnode cellid='3' mode='strict' nodeset='17'/>

Actual result
=============

Wrong cellid:

    <memnode cellid='0' mode='strict' nodeset='0'/>

    <memnode cellid='1' mode='strict' nodeset='1'/>

    <memnode cellid='16' mode='strict' nodeset='16'/>

    <memnode cellid='17' mode='strict' nodeset='17'/>

Environment
===========

Ubuntu Xenial 16.10, OpenStack Mitaka release, Libvirt 1.3.1

Note: This issue has been found / tested on Ubuntu KVM on Power (ppc64le arch), however, it *may* affect other architectures.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/340599

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/340599
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b327006e8cd335c75e97aeebec48940f3f960962
Submitter: Jenkins
Branch: master

commit b327006e8cd335c75e97aeebec48940f3f960962
Author: Rafael Folco <email address hidden>
Date: Mon Jul 11 22:07:14 2016 +0000

    Fix incorrect cellid numbering for NUMA memnode

    cellid should contain node index, but it actually has the cell nodeset.
    For the given node topology cells: 0 1 16 17
    Wrong cellid:
        <memnode cellid='0' mode='strict' nodeset='0'/>
        <memnode cellid='1' mode='strict' nodeset='1'/>
        <memnode cellid='16' mode='strict' nodeset='16'/>
        <memnode cellid='17' mode='strict' nodeset='17'/>
    Correct cellid:
        <memnode cellid='0' mode='strict' nodeset='0'/>
        <memnode cellid='1' mode='strict' nodeset='1'/>
        <memnode cellid='2' mode='strict' nodeset='16'/>
        <memnode cellid='3' mode='strict' nodeset='17'/>

    Change-Id: Iae337410492879a7964bcbb4711b057b920bdf79
    Closes-Bug: #1602023

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0b3 development milestone.