remotefs.RsyncDriver() should use utils.safe_ip_format()

Bug #1601822 reported by Alexey I. Froloff on 2016-07-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Alexey I. Froloff

Bug Description

IPv6 address literal should be wrapped in square brackets when calling rsync:

Resize error: not able to execute ssh command: Unexpected error while running command.
Command: rsync --archive --relative --no-implied-dirs /tmp/tmpo_wpSz/./var/lib/nova/instances/fd7c6610-cf13-42e0-826c-3b4eb2494465 fd4b:cafe:dead:beef::bad:f00d:/
Exit code: 255
Stdout: u''
Stderr: u'ssh: Could not resolve hostname fd4b: Name or service not known\r\nrsync: connection unexpectedly closed (0 bytes received so far) [sender]\nrsync error: unexplained error (code 255) at io.c(226) [sender=3.1.0]\n'

Changed in nova:
assignee: nobody → Alexey I. Froloff (raorn)
status: New → In Progress
Matt Riedemann (mriedem) on 2016-07-11
tags: added: ipv6 libvirt volumes
Changed in nova:
importance: Undecided → Medium
tags: added: mitaka-backport-potential

Reviewed: https://review.openstack.org/340386
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=270be6906c13bc621a7ad507b8ae729a940609d2
Submitter: Jenkins
Branch: master

commit 270be6906c13bc621a7ad507b8ae729a940609d2
Author: Alexey I. Froloff <email address hidden>
Date: Mon Jul 11 16:31:09 2016 +0300

    Properly quote IPv6 address in RsyncDriver

    When IPv6 address literal is used as host in rsync call, it should be
    enclosed in square brackets. This is already done for copy_file method
    outside of driver in changeset Ia5f28673e79158d948980f2b3ce496c6a56882af

    Create helper function format_remote_path(host, path) and use where
    appropriate.

    Closes-Bug: 1601822
    Change-Id: Ifc386539f33684fb764f5f638a7ee0a10b1ef534

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 14.0.0.0b3 development milestone.

Reviewed: https://review.openstack.org/357226
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fe21d29fa8b02f3e6437f035b0af6c58f8f454bb
Submitter: Jenkins
Branch: stable/mitaka

commit fe21d29fa8b02f3e6437f035b0af6c58f8f454bb
Author: Alexey I. Froloff <email address hidden>
Date: Mon Jul 11 16:31:09 2016 +0300

    Properly quote IPv6 address in RsyncDriver

    When IPv6 address literal is used as host in rsync call, it should be
    enclosed in square brackets. This is already done for copy_file method
    outside of driver in changeset Ia5f28673e79158d948980f2b3ce496c6a56882af

    Create helper function format_remote_path(host, path) and use where
    appropriate.

    Closes-Bug: 1601822
    Change-Id: Ifc386539f33684fb764f5f638a7ee0a10b1ef534
    (cherry picked from commit 270be6906c13bc621a7ad507b8ae729a940609d2)

tags: added: in-stable-mitaka

This issue was fixed in the openstack/nova 13.1.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers