'tox -e docs' fails due to wrong JSON format

Bug #1600070 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Natsume

Bug Description

The JSON format check fails when executing 'tox -e docs'.

stack@devstack-master:/tmp/nova$ tox -e docs
(snipped...)
docs runtests: commands[2] | bash -c ! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python
python -m json.tool doc/api_samples/os-assisted-volume-snapshots/snapshot-create-assisted-req.json
Expecting property name: line 9 column 9 (char 309)
ERROR: InvocationError: '/bin/bash -c ! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'
_________________________________________________________________________________________________ summary _________________________________________________________________________________________________
ERROR: docs: commands failed

[Environmant]
OS: Ubuntu 14.04.4 LTS (64bit)
nova: master(commit: 8f5c2c0447886c6a2877ea9ca6484045d5597dd9)

Changed in nova:
assignee: nobody → Takashi NATSUME (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/339295

Changed in nova:
status: New → In Progress
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Gate didn't discover this as they use:

    tox -e$venv -- python setup.py build_sphinx

to build the docs [1]. Could there be a missing link in the Nova docs which excludes the build of the api samples?

References:
[1] http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/run-docs.sh#n20

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/339295
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=31ad01f0f17af9b5e24d40785b83ff20ed61691a
Submitter: Jenkins
Branch: master

commit 31ad01f0f17af9b5e24d40785b83ff20ed61691a
Author: Takashi NATSUME <email address hidden>
Date: Fri Jul 8 10:09:36 2016 +0900

    Fix wrong JSON format in API samples

    Fix wrong JSON format in snapshot-create-assisted-req.json.

    Change-Id: I0817171bd7bc67384d4c40854ce5dc2952b38cfa
    Closes-Bug: #1600070

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/nova 14.0.0.0b2

This issue was fixed in the openstack/nova 14.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.