OpenStack Compute (nova)

Use URIOpt

Bug #1599034 reported by Masaki Matsushita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Takashi Natsume
OpenStack DBaaS (Trove)
Fix Released
Undecided
Masaki Matsushita

Bug Description

oslo.config introduced URIOpt in 3.12.
We can use this for validate URL configs.

Masaki Matsushita (mmasaki)
Changed in nova:
assignee: nobody → Masaki Matsushita (mmasaki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337477

Changed in nova:
status: New → In Progress
Revision history for this message
Masaki Matsushita (mmasaki) wrote :

https://review.openstack.org/#/c/338030/

Changed in trove:
assignee: nobody → Masaki Matsushita (mmasaki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/338030
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b5bd80f9ac479ffe262541edac91986cb22af0ad
Submitter: Jenkins
Branch: master

commit b5bd80f9ac479ffe262541edac91986cb22af0ad
Author: Masaki Matsushita <email address hidden>
Date: Wed Jul 6 15:33:44 2016 +0900

    Improve Config Validation

    This commit improves configuration validation.

    * URIOpt to validate URL strings.
    * HostnameOpt to validate hostnames

    Change-Id: I4a6edf1faafbd242ca652df9a1eacd941288774a
    Closes-Bug: #1599034

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/trove 6.0.0.0b3

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/337477
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → New
assignee: Masaki Matsushita (mmasaki) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/479215

Changed in nova:
assignee: nobody → Takashi NATSUME (natsume-takashi)
status: New → In Progress
Takashi Natsume (natsume-takashi)
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/479215
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=463fd7a11baa7618e14e355b162c06f3ccf2c2b2
Submitter: Jenkins
Branch: master

commit 463fd7a11baa7618e14e355b162c06f3ccf2c2b2
Author: Takashi NATSUME <email address hidden>
Date: Fri Jun 30 17:20:52 2017 +0900

    Use URIOpt

    Replace StrOpt with URIOpt.
    But 'serial_port_service_uri' in nova/conf/vmware.py
    is excluded because it can be non URI format(*1).

    *1: https://github.com/openstack/vmware-vspc/blob/master/README.rst

    Change-Id: I595c55798b482009c42261c3603a58f82e89877c
    Closes-Bug: #1599034

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b3

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.