Delete duplicate check when live-migrating

Bug #1598661 reported by Hiroyuki Eguchi on 2016-07-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Feodor Tersin

Bug Description

A year ago I fixed a bug: https://review.openstack.org/#/c/195885/
The launchpad report: https://bugs.launchpad.net/nova/+bug/1469006

A above patch makes live-migration enable when instance is booted volume and has not local disk.

A above patch performs the check via a call of _is_booted_from_volume and
check the result if other checks (check_dest_data['is_shared_block_storage']) fails.

However, this check has been already checked in _is_shared_block_storage method.

The last part of the _is_shared_block_storage method does the same that above patch does:
 - check whether the instance is booted from volume.
 - check whether the instance has not a local disk.

Changed in nova:
assignee: nobody → Hiroyuki Eguchi (h-eguchi)

Fix proposed to branch: master
Review: https://review.openstack.org/337056

Changed in nova:
status: New → In Progress
Andrea Rosa (andrea-rosa-m) wrote :

There is already a fix under review for this issue: https://review.openstack.org/#/c/334609/2

That change is not strictly related to this bug but as side-effect it fixes it.

Changed in nova:
assignee: Hiroyuki Eguchi (h-eguchi) → Feodor Tersin (ftersin)
Matt Riedemann (mriedem) on 2016-11-04
tags: added: libvirt live-migration
melanie witt (melwitt) on 2016-12-01
Changed in nova:
importance: Undecided → Low

Reviewed: https://review.openstack.org/337056
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=033d4d268960b18af806fdbe1bb2c1122d09782f
Submitter: Jenkins
Branch: master

commit 033d4d268960b18af806fdbe1bb2c1122d09782f
Author: Hiroyuki Eguchi <email address hidden>
Date: Mon Jul 4 08:14:25 2016 +0000

    libvirt: Delete duplicate check when live-migrating

    A year ago a useless check was added: I7989128d

    The above patch was aimed to enable live-migration when
    instance is booted from volume and has not local disk
    by adding a new check.

    However, the same check has been already checked in
    _is_shared_block_storage method.

    The last part of the _is_shared_block_storage method does
    the same that above patch does:
    - check whether the instance is booted from volume
    - check whether the instance has not a local disk

    Also this check calls _is_booted_from_volume incorrectly.
    Parameter disk_mapping of _is_booted_from_volume must be a dict, but
    this check specifies a string instead.

    And finally introduced _has_local_disk method is wrong, because
    it does not take into accont disk.ephN names.

    This change reverts I7989128d, improves and simplifies related tests.

    Closes-Bug: 1598661
    Related-Bug: 1469006
    Co-Authored-By: Feodor Tersin <email address hidden>
    Change-Id: Id59012547c3318d94b65ab9f7c37c33c3a08b0e0

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 15.0.0.0b2 development milestone.

Reviewed: https://review.openstack.org/416557
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5b2808c92c730075cfc84d5a019d52e883973ffd
Submitter: Jenkins
Branch: stable/newton

commit 5b2808c92c730075cfc84d5a019d52e883973ffd
Author: Hiroyuki Eguchi <email address hidden>
Date: Mon Jul 4 08:14:25 2016 +0000

    libvirt: Delete duplicate check when live-migrating

    A year ago a useless check was added: I7989128d

    The above patch was aimed to enable live-migration when
    instance is booted from volume and has not local disk
    by adding a new check.

    However, the same check has been already checked in
    _is_shared_block_storage method.

    The last part of the _is_shared_block_storage method does
    the same that above patch does:
    - check whether the instance is booted from volume
    - check whether the instance has not a local disk

    Also this check calls _is_booted_from_volume incorrectly.
    Parameter disk_mapping of _is_booted_from_volume must be a dict, but
    this check specifies a string instead.

    And finally introduced _has_local_disk method is wrong, because
    it does not take into accont disk.ephN names.

    This change reverts I7989128d, improves and simplifies related tests.

    Closes-Bug: 1598661
    Related-Bug: 1469006
    Co-Authored-By: Feodor Tersin <email address hidden>
    Change-Id: Id59012547c3318d94b65ab9f7c37c33c3a08b0e0
    (cherry picked from commit 033d4d268960b18af806fdbe1bb2c1122d09782f)

tags: added: in-stable-newton

This issue was fixed in the openstack/nova 14.0.4 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers