network_data.json shouldn't include internal device name and type

[Mathieu Gagné]

Nova currently injects in network_data.json the internal device name in the link id field and the device "type" in the link type field. This is wrong and could mislead users about how they should use and interpret those values.

The nova-specs for network_data.json [1] specifies that:
* the link id should be a "Generic, generated ID".
* the link type should be "vif" if it's a virtual interface and "phy" for physical interface.

The values currently used come from internal implementation details and shouldn't be passed on to the end-user. The implementation should be updated to respect the spirit of the spec. This will reduce confusion to initialization agent developers.

[1] http://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/metadata-service-network-info.html#rest-api-impact

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/324054

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/324054
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

Automatically discovered version liberty in description. If this is incorrect, please update the description to include 'nova version: ...'

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.