Nova should not inspect cinder volume state during attach
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Ildiko Vancsa |
Bug Description
The Nova API shouldn't be looking at the internal state of a Cinder volume to determine if it can attach. It should simply ask Cinder to reserve the volume. Cinder already has checks during reserve time for checking states.
Nova currently fetches a volume from Cinder, then checks to see if the state of the volume is in an appropriate state to attach, and then calls reserve. The problem is 2 fold.
1) Nova shouldn't care about the internal state management of Cinder Volumes. What happens if Cinder adds a new state that Nova doesn't know about?
2) By fetching a volume and checking, and then reserving, there is a race condition introduced. The state of the volume can change between the time the volume is fetched from Cinder and when reserve is called.
Nova should simply call reserve volume.
Changed in nova: | |
assignee: | nobody → Walt Boring (walter-boring) |
tags: | added: volumes |
Changed in nova: | |
assignee: | Walt Boring (walter-boring) → Ildiko Vancsa (ildiko-vancsa) |
Changed in nova: | |
importance: | Undecided → Medium |
Changed in nova: | |
assignee: | Ildiko Vancsa (ildiko-vancsa) → John Griffith (john-griffith) |
Changed in nova: | |
assignee: | John Griffith (john-griffith) → Ildiko Vancsa (ildiko-vancsa) |
Changed in nova: | |
assignee: | Ildiko Vancsa (ildiko-vancsa) → Matt Riedemann (mriedem) |
Changed in nova: | |
assignee: | Matt Riedemann (mriedem) → Ildiko Vancsa (ildiko-vancsa) |
Fix proposed to branch: master /review. openstack. org/315789
Review: https:/