OpenStack Compute (nova)

Service version does not update on restart

Bug #1579839 reported by Brian Elliott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Brian Elliott
Mitaka
Fix Released
High
Brian Elliott

Bug Description

When a new version of nova is installed with a corresponding new service version (nova.objects.service.SERVICE_VERSION), the DB is not correctly updated on restart to reflect the new version in the services table.

Brian Elliott (belliott)
tags: added: upgrades
tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314230

Changed in nova:
assignee: nobody → Brian Elliott (belliott)
status: New → In Progress
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/314230
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=854c39e26d94f006f539ea993ffaafa4892b100c
Submitter: Jenkins
Branch: master

commit 854c39e26d94f006f539ea993ffaafa4892b100c
Author: Brian Elliott <email address hidden>
Date: Mon May 9 18:45:58 2016 +0000

    Fix service version to update the DB

    When new code is installed with a newer service version, the version in
    the DB should get updated.

    The fix here is to:
    1) eliminate the special case for 'version' in save()
    2) cause version to be saved on startup

    Change-Id: I96fa9dabfb9b7a5f1703baf80534d8b104dab4e6
    Closes-Bug: 1579839

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/317662

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/nova 14.0.0.0b1

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/mitaka)

Reviewed: https://review.openstack.org/317662
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f044f44fd442c549abff974c7e892f58133076d0
Submitter: Jenkins
Branch: stable/mitaka

commit f044f44fd442c549abff974c7e892f58133076d0
Author: Brian Elliott <email address hidden>
Date: Mon May 9 18:45:58 2016 +0000

    Fix service version to update the DB

    When new code is installed with a newer service version, the version in
    the DB should get updated.

    The fix here is to:
    1) eliminate the special case for 'version' in save()
    2) cause version to be saved on startup

    NOTE(lyarwood): Single conflict caused by the use of Mock 1.3.0 on
    stable/mitaka and as a result the lack of assert_called_once().

    Conflicts:
            nova/tests/unit/test_service.py

    Change-Id: I96fa9dabfb9b7a5f1703baf80534d8b104dab4e6
    Closes-Bug: 1579839
    (cherry picked from commit 854c39e26d94f006f539ea993ffaafa4892b100c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 13.1.2

This issue was fixed in the openstack/nova 13.1.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.