Nova 'ComputeManager._build_and_run_instance' method sends inappropriate notification ('create.end')

Bug #1578500 reported by Wenzhi Yu on 2016-05-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Rajesh Tailor

Bug Description

In Nova 'ComputeManager._build_and_run_instance' method, if InstanceNotFound or UnexpectedDeletingTaskStateError raises, 'compute.instance.create.end' notification will be sent[1]. It would be more reasonable if we send 'compute.instance.create.error' notification instead.

[1]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/compute/manager.py#L2072

Fix proposed to branch: master
Review: https://review.openstack.org/312887

Changed in nova:
assignee: Wenzhi Yu (yuywz) → Rajesh Tailor (ratailor)
tags: added: notifications
Changed in nova:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/312887
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=19cc6e2ca897e65a630dfb3905ca62e8101d5b2e
Submitter: Jenkins
Branch: master

commit 19cc6e2ca897e65a630dfb3905ca62e8101d5b2e
Author: Rajesh Tailor <email address hidden>
Date: Thu May 5 06:11:25 2016 -0400

    Fix inappropriate notification send

    The method '_build_and_run_instance' sends inappropriate
    notification 'create.end' when an exception is raised, instead
    it should be sending 'create.error' notification.

    Replaced 'create.end' notification with 'create.error'
    when exception is raised.

    Change-Id: I2661cc47b6ebb674cce2f2b43851aa9eca12b5f8
    Closes-Bug:1578500

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers