Nova API fails to start if "ec2" is specified in enabled_apis

[Sean Dague]

As reported by Kevin Foxx yesterday, if "ec2" is listed in enabled_apis in Mitaka and beyond Nova will refuse to start because we removed it.

We assumed the change in defaults was good enough for people to move forward, but didn't realize that many of the install tools (packstack for sure) hardcoded this value into the config instead of sticking with the defaults.

While we've added a new upgrade note on this, we could also actually catch the error and not crash people.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308264

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/309600

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/309601

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308264
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=533bd8175968a1bc9ac068ae2b23a62d0e07ea99
Submitter: Jenkins
Branch: master

commit 533bd8175968a1bc9ac068ae2b23a62d0e07ea99
Author: Sean Dague <email address hidden>
Date: Wed Apr 20 06:53:18 2016 -0400

    Prevent nova-api from dying if enabled_apis is wrong

    This prevents nova-api from dying if there are values in
    ``enabled_apis`` which don't actually exist.

    Closes-Bug: #1572495

    Change-Id: Id9a6f5e38b017f4687eb245fd238104379d437d6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312108

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309600
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8182a550433c2db901ae9b926d8a44a1e23ad380
Submitter: Jenkins
Branch: master

commit 8182a550433c2db901ae9b926d8a44a1e23ad380
Author: Dan Smith <email address hidden>
Date: Fri Apr 22 14:15:14 2016 -0700

    Test that nova-api ignores paste failures, but continues on

    Change-Id: I3232016c61f7a598d15b9e8a11a9975f5cfad3d0
    Related-Bug: #1572495

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309601
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9b2329d10021a7fa5f43b9fd8be3c833dd7212d0
Submitter: Jenkins
Branch: master

commit 9b2329d10021a7fa5f43b9fd8be3c833dd7212d0
Author: Dan Smith <email address hidden>
Date: Fri Apr 22 14:22:08 2016 -0700

    Fail to start nova-api if no APIs were able to be started

    This helps to make it clear that either you specified no API services,
    or you specified all bad ones, or that you fat-fingered the thing
    entirely. If we can't start any, we shouldn't start the process acting
    like we did and then wait for you to figure out the hard way that we
    aren't actually listening for any requests.

    Change-Id: I864486a58cf3fde35647ae3b8d2ad917c809ea54
    Related-Bug: #1572495

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312194

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312195

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312108
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=53c6c99f2b4221e20c29a4a24cbef33732a75a17
Submitter: Jenkins
Branch: stable/mitaka

commit 53c6c99f2b4221e20c29a4a24cbef33732a75a17
Author: Sean Dague <email address hidden>
Date: Wed Apr 20 06:53:18 2016 -0400

    Prevent nova-api from dying if enabled_apis is wrong

    This prevents nova-api from dying if there are values in
    ``enabled_apis`` which don't actually exist.

    Closes-Bug: #1572495

    Change-Id: Id9a6f5e38b017f4687eb245fd238104379d437d6
    (cherry picked from commit 533bd8175968a1bc9ac068ae2b23a62d0e07ea99)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312194
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8ec57fb1557ebab6edb2bba35b6a4f227c270959
Submitter: Jenkins
Branch: stable/mitaka

commit 8ec57fb1557ebab6edb2bba35b6a4f227c270959
Author: Dan Smith <email address hidden>
Date: Fri Apr 22 14:15:14 2016 -0700

    Test that nova-api ignores paste failures, but continues on

    Change-Id: I3232016c61f7a598d15b9e8a11a9975f5cfad3d0
    Related-Bug: #1572495
    (cherry picked from commit 8182a550433c2db901ae9b926d8a44a1e23ad380)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312195
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e80a87352431ee6f05729be32296e90b2d9c13c7
Submitter: Jenkins
Branch: stable/mitaka

commit e80a87352431ee6f05729be32296e90b2d9c13c7
Author: Dan Smith <email address hidden>
Date: Fri Apr 22 14:22:08 2016 -0700

    Fail to start nova-api if no APIs were able to be started

    This helps to make it clear that either you specified no API services,
    or you specified all bad ones, or that you fat-fingered the thing
    entirely. If we can't start any, we shouldn't start the process acting
    like we did and then wait for you to figure out the hard way that we
    aren't actually listening for any requests.

    Change-Id: I864486a58cf3fde35647ae3b8d2ad917c809ea54
    Related-Bug: #1572495
    (cherry picked from commit 9b2329d10021a7fa5f43b9fd8be3c833dd7212d0)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.1.0 release.