create snapshot failed with libvirt error which can pass

[Jinquan Ni]

Create instance’s snapshot failed with libvirt error.

 The error msg as follow：

libvirtError (\'virDomainBlockJobAbort() failed\', dom=self)\n'
libvirtError: Requested operation is not valid: No active operation on device: drive-virtio-disk0\n'

“virDomainBlockJobAbort” used to abort block job, the error will be raise if device has no block job.

Pass this exception is the correct way to handling. However, the current process did not do.

[Sylvain Bauza (sylvain-bauza)]

Not sure it's a Nova error, rather a libvirt one. Could you please provide us your nova version and your libvirt one ?

[Jinquan Ni (ni-jinquan)]

dear Sylvain Bauza：

   My nova version is kilo 2015.1.0, libvirt version is 1.2.21.
   And this proplem should exist in Mitaka by reading the code in driver.py.

   I am not very sure that the bug belongs nova or the libvirt at first. But i report this bug to here finally , it‘s base on follow point：
   libvirt think abort job on device which has no job should raise error. libvirt provide a method that check whether the device has job.
   The view is reasonable considering the error will also be raise when we pop a non-exist key from some dict.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/307808

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/337226

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jinquan Ni (<email address hidden>) on branch: master
Review: https://review.openstack.org/307808
Reason: My colleague already post a new patch set for this bug.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/337226
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Launchpad Janitor (janitor)]

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]