Database Poison Warnings

[Diana Clarke]

The following warning appears a number of times in the unit test logs. Use this bug to track the patches that eliminate these warnings.

"UserWarning: This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later."

Note that this warning is only emitted once per unit test worker, so new offenders will show up in the logs each time you fix a test until they are all gone.

Once all of these warnings are removed, change the warning to an exception so that we don't get more of these in the future.

[Diana Clarke (diana-clarke)]

The first patch set in a multi-patch approach: https://review.openstack.org/#/c/303669/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/303669
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f64237d89056d75300aa9cafaed679b728407261
Submitter: Jenkins
Branch: master

commit f64237d89056d75300aa9cafaed679b728407261
Author: Diana Clarke <email address hidden>
Date: Fri Apr 8 20:55:59 2016 -0400

    Fix database poison warnings

    The following warning appears in the unit test logs a number of times.
    This patch fixes some of those warnings by mocking the get instance
    calls higher up (Instance.get_by_uuid vs. db.instance_get_by_uuid).

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later.

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Related-Bug: #1568414
    Change-Id: I76422d8c13559322bba0be0c24882330fb947af1

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/306676

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/306887

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306887
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=70de70c71cffd849bdf533967af689e339cf558f
Submitter: Jenkins
Branch: master

commit 70de70c71cffd849bdf533967af689e339cf558f
Author: Diana Clarke <email address hidden>
Date: Sun Apr 17 21:42:01 2016 -0400

    Fix database poison warnings, part 3

    The following warning appears in the unit test logs a number of times.
    This patch fixes the warnings in ComputeAPIAPICellUnitTestCase.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: Idcd733df2aafe809cb89f2a1db5df6ad227dd39c
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306676
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2acc8960c541993ffd733f904ff3c444ed280ac2
Submitter: Jenkins
Branch: master

commit 2acc8960c541993ffd733f904ff3c444ed280ac2
Author: Diana Clarke <email address hidden>
Date: Fri Apr 15 22:14:14 2016 -0400

    Fix database poison warnings, part 2

    The following warning appears in the unit test logs a number of times.
    This patch fixes some of those warnings by stubbing at the object layer
    rather than the database layer.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I29dca2fd07c7b106a51fb1608caa87b1a5548863
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/309644

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/310325

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/310334

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/310631

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/311866

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310325
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5e4c9dec01cb841280e3e9e7a5b9473edd14c539
Submitter: Jenkins
Branch: master

commit 5e4c9dec01cb841280e3e9e7a5b9473edd14c539
Author: Diana Clarke <email address hidden>
Date: Tue Apr 26 18:33:20 2016 -0400

    Fix database poison warnings, part 5

    The following warning appears in the unit test logs a number of times.
    This patch fixes the last warnings in unit.compute.test_compute_api.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I9f81e22fda8dbab2007aa7d2aa972b9dce364b5f
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309644
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b554a8c2232889fe1ea53ba5ae42b30c057c5a58
Submitter: Jenkins
Branch: master

commit b554a8c2232889fe1ea53ba5ae42b30c057c5a58
Author: Diana Clarke <email address hidden>
Date: Fri Apr 22 23:32:53 2016 -0400

    Fix database poison warnings, part 4

    The following warning appears in the unit test logs a number of times.
    This patch fixes 30 of those warnings from virt.libvirt.test_driver, but
    there are still a bunch more in that file.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I6eb16fbd1eaac6da9f4e75506729eaf050bda1cf
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310334
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c263995b13a837997fd843be1069b7d14b9befdc
Submitter: Jenkins
Branch: master

commit c263995b13a837997fd843be1069b7d14b9befdc
Author: Diana Clarke <email address hidden>
Date: Tue Apr 26 21:27:58 2016 -0400

    Fix database poison warnings, part 6

    The following warning appears in the unit test logs a number of times.
    This patch fixes all the warnings in unit.compute.test_compute_utils.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I593c9f7a2d5f688fe316347c61c34339b79e8929
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310631
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a44d9995f4de6a44549ebdc517f550a454cefa65
Submitter: Jenkins
Branch: master

commit a44d9995f4de6a44549ebdc517f550a454cefa65
Author: Diana Clarke <email address hidden>
Date: Wed Apr 27 21:00:51 2016 -0400

    Fix database poison warnings, part 7

    The following warning appears in the unit test logs a number of times.
    This patch fixes all the warnings in unit.compute.test_compute_mgr.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: Ie9a3f3a1d5f38fb81fff37922753dfca10b96531
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311866
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cf9713f3a4ec583c2035f7b7595ba96a0b1edcde
Submitter: Jenkins
Branch: master

commit cf9713f3a4ec583c2035f7b7595ba96a0b1edcde
Author: Diana Clarke <email address hidden>
Date: Mon May 2 17:42:50 2016 -0400

    Fix database poison warnings, part 8

    The following warning appears in the unit test logs a number of times.
    This patch fixes the warnings in virt.libvirt.test_driver that come from
    driver._get_connection() calls, but there are still a bunch more
    warnings in that file.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: Icacce09f8a83cb4c73d5b6caf5cd31b55032c847
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/345640

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/345683

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/346172

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/346239

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/347006

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/347531

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/349082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345640
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=46cf8afa1758d07f5ece2a52517aa16adb2812fd
Submitter: Jenkins
Branch: master

commit 46cf8afa1758d07f5ece2a52517aa16adb2812fd
Author: Diana Clarke <email address hidden>
Date: Thu Jul 21 15:47:45 2016 -0400

    Fix database poison warnings, part 9

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        unit.api.openstack.compute.test_keypairs.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I4284dd7ecb9c60834dba662838f67d9defc798e2
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346239
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e245086498d3b17203d52e1c9b4d09734788bee7
Submitter: Jenkins
Branch: master

commit e245086498d3b17203d52e1c9b4d09734788bee7
Author: Diana Clarke <email address hidden>
Date: Fri Jul 22 17:22:53 2016 -0400

    Fix database poison warnings, part 12

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes the last two warnings from:

        unit.compute.test_compute_api.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I8fefd8228f2aa9490cab943a79c50e76b1e66fa8
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345683
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0d814ac4371a3fcc4d60daa3bee2fde928231303
Submitter: Jenkins
Branch: master

commit 0d814ac4371a3fcc4d60daa3bee2fde928231303
Author: Diana Clarke <email address hidden>
Date: Thu Jul 21 17:53:34 2016 -0400

    Fix database poison warnings, part 10

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        unit.compute.test_compute_mgr.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I72da6b07a854a69c275258027afa73e7bfaeba17
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347006
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=131686f66c80834470529eb70710dbeffbbaad96
Submitter: Jenkins
Branch: master

commit 131686f66c80834470529eb70710dbeffbbaad96
Author: Diana Clarke <email address hidden>
Date: Mon Jul 25 14:00:32 2016 -0600

    Fix database poison warnings, part 13

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes the warnings from:

        unit.virt.vmwareapi.test_driver_api.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I2dd21ec8c970161f695b2f37ae0973343678a0c4
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346172
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=af9aa1c24f810633ee0a5efacb84518c3e4e6c5d
Submitter: Jenkins
Branch: master

commit af9aa1c24f810633ee0a5efacb84518c3e4e6c5d
Author: Diana Clarke <email address hidden>
Date: Fri Jul 22 14:27:37 2016 -0400

    Fix database poison warnings, part 11

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes the one warning from:

        unit.virt.libvirt.test_imagecache.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I057852125249d41d0b645a68013fef62249a2af7
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/375891

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/375894

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/375895

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/375899

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/376607

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/377001

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/377051

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/377991

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375894
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2f670bf40c6de91bff1fe046c8c4f5eb81d8ccbb
Submitter: Jenkins
Branch: master

commit 2f670bf40c6de91bff1fe046c8c4f5eb81d8ccbb
Author: Diana Clarke <email address hidden>
Date: Sat Sep 24 15:40:15 2016 -0400

    Fix database poison warnings, part 16

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.api.openstack.compute.test_shelve.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I39cca6587f99cfe6f980b6d8fe857618fac6bb5a
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375895
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8c753e9a8438010b274314d86b71dc50249043e3
Submitter: Jenkins
Branch: master

commit 8c753e9a8438010b274314d86b71dc50249043e3
Author: Diana Clarke <email address hidden>
Date: Sat Sep 24 15:55:35 2016 -0400

    Fix database poison warnings, part 17

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.api.openstack.compute.test_serversV21.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I88264e54fd135e56612ae3066e1c160f6643f9c4
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375899
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e71f706e56112594e029a44747a4263280c100c6
Submitter: Jenkins
Branch: master

commit e71f706e56112594e029a44747a4263280c100c6
Author: Diana Clarke <email address hidden>
Date: Sat Sep 24 16:21:40 2016 -0400

    Fix database poison warnings, part 18

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.api.openstack.compute.test_instance_actions.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I4ed976cac15de31fe975b7a15496bf2f2faea40b
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375891
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0ada84cc541bd1b302016e657a313d7e7d19d0c5
Submitter: Jenkins
Branch: master

commit 0ada84cc541bd1b302016e657a313d7e7d19d0c5
Author: Diana Clarke <email address hidden>
Date: Sat Sep 24 14:54:49 2016 -0400

    Fix database poison warnings, part 15

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        unit.compute.test_compute_mgr.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I4529b4bdc13b4079b1274034b44a1f44922c3bf2
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347531
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d98096bd92371ac9ef95cf61b683ba048ce07fe3
Submitter: Jenkins
Branch: master

commit d98096bd92371ac9ef95cf61b683ba048ce07fe3
Author: Diana Clarke <email address hidden>
Date: Tue Jul 26 13:21:19 2016 -0600

    Fix database poison warnings, part 14

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes the warnings from:

        unit.virt.xenapi.test_xenapi.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I41537e6b062b169cc6934d525560eb96ca58c55b
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376607
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=62e818ab1480c9c3584d342cda0872949a46368f
Submitter: Jenkins
Branch: master

commit 62e818ab1480c9c3584d342cda0872949a46368f
Author: Diana Clarke <email address hidden>
Date: Mon Sep 26 11:51:52 2016 -0400

    Fix database poison warnings, part 19

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.virt.ironic.test_driver.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I4181775eb0e89e8a21e6af8dddb3c9ffd09a6b83
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377051
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=57672202e936f42eeb1d7466e5896d047e6fa6b5
Submitter: Jenkins
Branch: master

commit 57672202e936f42eeb1d7466e5896d047e6fa6b5
Author: Diana Clarke <email address hidden>
Date: Mon Sep 26 15:20:28 2016 -0400

    Fix database poison warnings, part 21

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.compute.test_compute_api.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I7bdf8422b050039df02c40a069964262dfe4a9eb
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377001
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9544906571004f59ba9f3ab2eab9de7878b95a9a
Submitter: Jenkins
Branch: master

commit 9544906571004f59ba9f3ab2eab9de7878b95a9a
Author: Diana Clarke <email address hidden>
Date: Mon Sep 26 14:18:12 2016 -0400

    Fix database poison warnings, part 20

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.compute.test_compute.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I4f3679bf97ec0240ede5beaf202ee3c60c230a8a
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377991
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=993a815e78d9a500bd187f4ce25c0a5826369b23
Submitter: Jenkins
Branch: master

commit 993a815e78d9a500bd187f4ce25c0a5826369b23
Author: Diana Clarke <email address hidden>
Date: Tue Sep 27 15:09:10 2016 -0400

    Fix database poison warnings, part 22

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings from:

        nova.tests.unit.api.openstack.compute.test_quotas.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I1f6d5e161abea3a66fe09159b84e100c123561bd
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/391474

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/391512

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391474
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b85f235515f7a56a42a864ea7a5bdd3f0f7b7835
Submitter: Jenkins
Branch: master

commit b85f235515f7a56a42a864ea7a5bdd3f0f7b7835
Author: Diana Clarke <email address hidden>
Date: Fri Oct 28 09:31:13 2016 -0400

    Fix database poison warnings, part 23

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings (12 new ones) from:

        nova.tests.unit.virt.ironic.test_driver.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I2f11c85a3fd192d93f010b781af60b78ff6914b9
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391512
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f7ed4b1b99be5d6ddb300ad0f783ce9cb931ea4d
Submitter: Jenkins
Branch: master

commit f7ed4b1b99be5d6ddb300ad0f783ce9cb931ea4d
Author: Diana Clarke <email address hidden>
Date: Fri Oct 28 10:56:17 2016 -0400

    Fix database poison warnings, part 24

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes all the warnings (7 new ones) from:

        unit.compute.test_compute_mgr.py

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: Ibe23b977f24a2840eee6f8386d7c0bbbab6783fa
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/394944

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/395052

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chris Dent (<email address hidden>) on branch: master
Review: https://review.openstack.org/395052
Reason: abandoned because edleafe fixed the parent proper like

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/396207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394944
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fcc826356022506e872bee38557a0c72a2454f9f
Submitter: Jenkins
Branch: master

commit fcc826356022506e872bee38557a0c72a2454f9f
Author: Chris Dent <email address hidden>
Date: Tue Nov 8 12:21:19 2016 +0000

    Fix database poison warnings in resource providers

    The introduction of the _ensure_rc_cache method in lots of places
    has caused new database poison errors in test_resource_provider.py.

    This changes fixes those issues by mocking the call to _ensure_rc_cache
    and the id_from_string/string_from_id methods of the cache object.

    Co-Authored-By: Ed Leafe <email address hidden>
    Related-Bug: #1568414
    Change-Id: Ib8828544772a6e738e43f20591c795d2ef9bf901

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/396207
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1078ebd6c1b1ba9a5d811a426caab7381c972369
Submitter: Jenkins
Branch: master

commit 1078ebd6c1b1ba9a5d811a426caab7381c972369
Author: Diana Clarke <email address hidden>
Date: Thu Nov 10 08:53:35 2016 -0500

    Fix database poison warnings, part 25

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    This patch fixes the only 2 warnings in the functional tests.

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    Change-Id: I1bce7ef4222f1188c003d84ce42cd4755e9d8c24
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/349082
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3a0117835525a1dc0d66930b19110a4343419ad6
Submitter: Jenkins
Branch: master

commit 3a0117835525a1dc0d66930b19110a4343419ad6
Author: Diana Clarke <email address hidden>
Date: Fri Jul 29 15:44:09 2016 -0600

    Change database poison warning to an exception

    The following warning appears in the unit test logs a number of times.

        "UserWarning: This test uses methods that set internal oslo_db
    state, but it does not claim to use the database. This will conflict
    with the setup of tests that do use the database and cause failures
    later."

    Note that this warning is only emitted once per unit test worker, so new
    offenders will show up in the logs each time you fix a test until they
    are all gone.

    This patch is intended to be merged after all the existing warnings are
    addressed by other patches in this series:

      https://review.openstack.org/#/q/topic:bug/1568414

    Change-Id: I91909a356187bac70fa2fa920cebf3888410ae01
    Closes-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/378679
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=03e2f0449adf021774578cb3b457e284e831a509
Submitter: Jenkins
Branch: master

commit 03e2f0449adf021774578cb3b457e284e831a509
Author: Diana Clarke <email address hidden>
Date: Wed Sep 28 10:51:04 2016 -0400

    EventReporterStub

    A number of tests in test_compute_mgr.py patch the event reporter to
    prevent database poison warnings but otherwise don't assert on the event
    reporter behaviour. Replace those individual mocks with a fixture that
    stubs out the event reporter in the test setUp.

    Change-Id: I57233259065d887b38a79850a05177fcbbdfb8c3
    Related-Bug: #1568414

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/399668

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399668
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=128318de82f62bd0ebcee856dfe7239c48bc5b64
Submitter: Jenkins
Branch: master

commit 128318de82f62bd0ebcee856dfe7239c48bc5b64
Author: Diana Clarke <email address hidden>
Date: Fri Nov 18 11:09:53 2016 -0500

    Database poison note

    Add a few tips for folks that encounter database poison exceptions.

    Change-Id: Ic54d9d2fdd100e20e020fb7944f1f7f16be82db0
    Related-Bug: #1568414