When VM creat failed, do not unplug-ports

[bailin.zhang]

When VM create failed (such as "_create_domain" execute failed), do not unplug-ports. This bug hit all release/branch.

When create the VM, It will update network-info at the process "update_instance_cache_with_nw_info".
But It only update the data in Data-base. the InstanceInfoCache of the local variable(instance) do not be updated.

If the VM is created failed at process "libvirt.driver._create_domain".
when shutdown the instance,it can not get the correct network information
So can not unplug-vif correctlly, there are some information is left

[bailin.zhang (bailin-zhang)]

Detail infomation: http://paste.openstack.org/show/493451/

[bailin.zhang (bailin-zhang)]

review address:

https://review.openstack.org/#/c/306219/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/331113

[OpenStack Infra (hudson-openstack)]

Change abandoned by bailin.zhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/306219

[Augustina Ragwitz (auggy)]

Resetting to New/Undecided because it's not clear that this bug has been triaged yet.

[bailin.zhang (bailin-zhang)]

 For more detail info:
 I will create a VM with vxlan network. The VM will be created failed at process "libvirt.driver._create_domain".

the current ovs-info:
[root@localhost ~]# brctl show
bridge name bridge id STP enabled interfaces
virbr0 8000.525400b00efc yes virbr0-nic
[root@localhost ~]#

create VM:
[root@localhost devstack]# nova list
+----+------+--------+------------+-------------+----------+
| ID | Name | Status | Task State | Power State | Networks |
+----+------+--------+------------+-------------+----------+
+----+------+--------+------------+-------------+----------+
[root@localhost devstack]# nova boot --flavor m1.tiny --image 5eff06a2-0078-4894-b150-3681c0a75e96 --nic net-id=9766bbdb-9f6c-42d3-abbe-d948ad95a1f5 vm_test
+--------------------------------------+----------------------------------------------------------------+
| Property | Value |
+--------------------------------------+----------------------------------------------------------------+
| OS-DCF:diskConfig | MANUAL |
| OS-EXT-AZ:availability_zone | |
| OS-EXT-SRV-ATTR:host | - |
| OS-EXT-SRV-ATTR:hostname | vm-test |
| OS-EXT-SRV-ATTR:hypervisor_hostname | - |
| OS-EXT-SRV-ATTR:instance_name | instance-00000002 |
| OS-EXT-SRV-ATTR:kernel_id | 92f607a2-3992-4b6e-b381-104f42619e53 |
| OS-EXT-SRV-ATTR:launch_index | 0 |
| OS-EXT-SRV-ATTR:ramdisk_id | 7cdd665d-0aed-4bbc-b582-bea9d955f076 |
| OS-EXT-SRV-ATTR:reservation_id | r-dgfe3hnw |
| OS-EXT-SRV-ATTR:root_device_name | - |
| OS-EXT-SRV-ATTR:user_data | - |
| OS-EXT-STS:power_state | 0 |
| OS-EXT-STS:task_state | scheduling |
| OS-EXT-STS:vm_state | building |
| OS-SRV-USG:launched_at | - |
| OS-SRV-USG:terminated_at | - |
| accessIPv4 | |
| accessIPv6 | |
| adminPass | uAx2X5SeU3k7 ...

[bailin.zhang (bailin-zhang)]

When create the VM, It will update network-info at the process "update_instance_cache_with_nw_info".
But It only update the data in Data-base. the InstanceInfoCache of the local variable(instance) do not be updated.
So when shutdown the instance, get to the wrong network information

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/331113
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Sean Dague (sdague)]

Is this still an active issue?

[Launchpad Janitor (janitor)]

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]