detach interface is not allowed when server is SOFT_DELETED

[Jiajun Liu]

I tested instance deferred delete function. I found that when a instance is SOFT_DELETED, I can detach volume from that instance. However I can't detach interface from a SOFT_DELETED instance. I think we should also allow interface detach operation when a instance is SOFT_DELETED.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302052

[Sylvain Bauza (sylvain-bauza)]

Not really sure we should accept to delete either volumes or network IFs when an instance is SOFT DELETED, but let's discuss that in the review change...

[Jiajun Liu (ljjjustin)]

Hi Sylvain, IMHO currently implementation of instance deferred delete function is strange.
1, It seems that it's a admin only function, normal user can't see and restore the deleted instance.
2, The operation of the resources associate with instance inconsistent. As a example: we can detach volume but we can't detach interface.
3, There is DOS risk because there is interval between the quota reclaime and resource reclaim. https://bugs.launchpad.net/nova/+bug/1501808
4, If instance have one or more attached volume, the volume can't be detach and leave a volume detached to a none instance. we have to modify cinder database to fix this kind problem. https://bugs.launchpad.net/nova/+bug/1560300
IMHO, we should refactor the instance deferred delete function.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/302052
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Sean Dague (sdague)]

This is working as designed. The soft_delete is for admins to save people's stuff, not for them to, and removing the interface makes the thing something they can't do.

There is no DOS vector if you don't enable soft_delete, which is disabled by default.