detach interface is not allowed when server is SOFT_DELETED

Bug #1566659 reported by Jiajun Liu on 2016-04-06
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)

Bug Description

I tested instance deferred delete function. I found that when a instance is SOFT_DELETED, I can detach volume from that instance. However I can't detach interface from a SOFT_DELETED instance. I think we should also allow interface detach operation when a instance is SOFT_DELETED.

Jiajun Liu (ljjjustin) on 2016-04-06
description: updated
Jiajun Liu (ljjjustin) on 2016-04-06
Changed in nova:
assignee: nobody → Jiajun Liu (ljjjustin)

Fix proposed to branch: master

Changed in nova:
status: New → In Progress
Sylvain Bauza (sylvain-bauza) wrote :

Not really sure we should accept to delete either volumes or network IFs when an instance is SOFT DELETED, but let's discuss that in the review change...

Changed in nova:
importance: Undecided → Low
Jiajun Liu (ljjjustin) wrote :

Hi Sylvain, IMHO currently implementation of instance deferred delete function is strange.
1, It seems that it's a admin only function, normal user can't see and restore the deleted instance.
2, The operation of the resources associate with instance inconsistent. As a example: we can detach volume but we can't detach interface.
3, There is DOS risk because there is interval between the quota reclaime and resource reclaim.
4, If instance have one or more attached volume, the volume can't be detach and leave a volume detached to a none instance. we have to modify cinder database to fix this kind problem.
IMHO, we should refactor the instance deferred delete function.

Change abandoned by Michael Still (<email address hidden>) on branch: master
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → New
assignee: Jiajun Liu (ljjjustin) → nobody
Sean Dague (sdague) wrote :

This is working as designed. The soft_delete is for admins to save people's stuff, not for them to, and removing the interface makes the thing something they can't do.

There is no DOS vector if you don't enable soft_delete, which is disabled by default.

Changed in nova:
status: New → Opinion
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers