db: 'allocations' table migration and model have conflicting indexes

[Matt Riedemann]

The spec for the 'allocations' table in nova says there will be an index over the resource_provider_id, resource_class_id and used columns.

That's in the data model definition:

https://github.com/openstack/nova/blob/9bc935d7d059c5ad9ff563b373691c3134e8f3ac/nova/db/sqlalchemy/models.py#L1503-L1505

        Index('allocations_resource_provider_class_used_idx',
              'resource_provider_id', 'resource_class_id',
              'used'),

It's not, however, in the database migration that adds the table to the schema:

https://github.com/openstack/nova/blob/9bc935d7d059c5ad9ff563b373691c3134e8f3ac/nova/db/sqlalchemy/migrate_repo/versions/314_add_resource_provider_tables.py#L71-L73

    Index('allocations_resource_provider_class_id_idx',
          allocations.c.resource_provider_id,
          allocations.c.resource_class_id)

So we probably need a new migration to fix that index.

[Chris Dent (cdent)]

It's in 318 from https://review.openstack.org/#/c/281837/ is it not?

[Jay Pipes (jaypipes)]

It is indeed. Matt, this was my fault. In the amended resource-providers spec:

https://review.openstack.org/#/c/283253/2/specs/mitaka/approved/resource-providers.rst

I changed the index. Chris subsequently corrected things in the patch referenced above.

-jay

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/298423

[Matt Riedemann (mriedem)]

Damn, OK, I guess it is handled in https://review.openstack.org/#/c/281837/ .

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/298423
Reason: This was already fixed in the 318 migration:

https://review.openstack.org/#/c/281837/