nova-novncproxy doesn't start when 'record' is specified

[Radoslav Gerganov]

$ /usr/local/bin/nova-novncproxy --record --config-file /etc/nova/nova.conf --web /opt/stack/noVNC

2016-03-18 12:34:01.940 CRITICAL nova [-] AttributeError: 'bool' object has no attribute 'startswith'

2016-03-18 12:34:01.940 TRACE nova Traceback (most recent call last):
2016-03-18 12:34:01.940 TRACE nova File "/usr/local/bin/nova-novncproxy", line 10, in <module>
2016-03-18 12:34:01.940 TRACE nova sys.exit(main())
2016-03-18 12:34:01.940 TRACE nova File "/opt/stack/nova/nova/cmd/novncproxy.py", line 39, in main
2016-03-18 12:34:01.940 TRACE nova port=CONF.vnc.novncproxy_port)
2016-03-18 12:34:01.940 TRACE nova File "/opt/stack/nova/nova/cmd/baseproxy.py", line 73, in proxy
2016-03-18 12:34:01.940 TRACE nova RequestHandlerClass=websocketproxy.NovaProxyRequestHandler
2016-03-18 12:34:01.940 TRACE nova File "/usr/local/lib/python2.7/dist-packages/websockify/websocketproxy.py", line 265, in __init__
2016-03-18 12:34:01.940 TRACE nova websocket.WebSocketServer.__init__(self, RequestHandlerClass, *args, **kwargs)
2016-03-18 12:34:01.940 TRACE nova File "/usr/local/lib/python2.7/dist-packages/websockify/websocket.py", line 647, in __init__
2016-03-18 12:34:01.940 TRACE nova self.record = os.path.abspath(record)
2016-03-18 12:34:01.940 TRACE nova File "/usr/lib/python2.7/posixpath.py", line 367, in abspath
2016-03-18 12:34:01.940 TRACE nova if not isabs(path):
2016-03-18 12:34:01.940 TRACE nova File "/usr/lib/python2.7/posixpath.py", line 61, in isabs
2016-03-18 12:34:01.940 TRACE nova return s.startswith('/')
2016-03-18 12:34:01.940 TRACE nova AttributeError: 'bool' object has no attribute 'startswith'
2016-03-18 12:34:01.940 TRACE nova

The 'record' argument should be string, not boolean.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/294512

[Matt Riedemann (mriedem)]

What version of websockify are you using?

[Matt Riedemann (mriedem)]

Looks like 0.8.0:

https://github.com/kanaka/websockify/blob/v0.8.0/websockify/websocket.py#L647

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/294512
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c5311439d6526006dd1354e09f2bfb86505d550d
Submitter: Jenkins
Branch: master

commit c5311439d6526006dd1354e09f2bfb86505d550d
Author: Radoslav Gerganov <email address hidden>
Date: Fri Mar 18 12:56:04 2016 +0200

    The 'record' option of the WebSocketProxy should be string

    If proxy service (VNC, spice, serial) is started with the 'record'
    option, an exception is thrown. This is because WebSocketProxy
    expects a file path for the record argument instead of boolean
    value. This patch fixes this by changing 'record' to be string
    option. An empty string means no recording.

    Closes-Bug: #1559026

    Change-Id: Id6cf7c65191bdaa579f7cdadea43230897436de6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/304730

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/304733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304730
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3c008718e15f0d2da717f04ff211e9da6d80ff2d
Submitter: Jenkins
Branch: stable/mitaka

commit 3c008718e15f0d2da717f04ff211e9da6d80ff2d
Author: Radoslav Gerganov <email address hidden>
Date: Fri Mar 18 12:56:04 2016 +0200

    The 'record' option of the WebSocketProxy should be string

    If proxy service (VNC, spice, serial) is started with the 'record'
    option, an exception is thrown. This is because WebSocketProxy
    expects a file path for the record argument instead of boolean
    value. This patch fixes this by changing 'record' to be string
    option. An empty string means no recording.

    Closes-Bug: #1559026

    Change-Id: Id6cf7c65191bdaa579f7cdadea43230897436de6
    (cherry picked from commit c5311439d6526006dd1354e09f2bfb86505d550d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304733
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=79a49b3d6a4221ca3e09cb16008cc423f1902fe7
Submitter: Jenkins
Branch: stable/liberty

commit 79a49b3d6a4221ca3e09cb16008cc423f1902fe7
Author: Radoslav Gerganov <email address hidden>
Date: Fri Mar 18 12:56:04 2016 +0200

    The 'record' option of the WebSocketProxy should be string

    If proxy service (VNC, spice, serial) is started with the 'record'
    option, an exception is thrown. This is because WebSocketProxy
    expects a file path for the record argument instead of boolean
    value. This patch fixes this by changing 'record' to be string
    option. An empty string means no recording.

    Closes-Bug: #1559026

    Change-Id: Id6cf7c65191bdaa579f7cdadea43230897436de6
    (cherry picked from commit c5311439d6526006dd1354e09f2bfb86505d550d)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 12.0.4 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.1.0 release.