tox -r -e docs fails on doc/notification_samples/service-update.json with "No JSON object could be decoded"

Bug #1553634 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sean Dague

Bug Description

Trunk nova as of today, tox -r -e docs fails with this:

python -m json.tool doc/notification_samples/service-update.json
No JSON object could be decoded

https://github.com/openstack/nova/commit/d411d60587e54dd364b7a329035726f2e281a9f7 might have broken it.

Matt Riedemann (mriedem)
tags: added: doc low-hanging-fruit
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Mohan (mmuppidi)
Changed in nova:
assignee: nobody → Mohan (mmuppidi)
Changed in nova:
assignee: Mohan (mmuppidi) → Rahul U Nair (rahulunair)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/289074

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/289477

Changed in nova:
assignee: Rahul U Nair (rahulunair) → Sean Dague (sdague)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/289477
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=235e0b04ea34b29cb16ccb003340cc9f8e980eae
Submitter: Jenkins
Branch: master

commit 235e0b04ea34b29cb16ccb003340cc9f8e980eae
Author: Sean Dague <email address hidden>
Date: Mon Mar 7 17:44:41 2016 +0000

    Revert "functional: Grab the service version from the module"

    This reverts commit d411d60587e54dd364b7a329035726f2e281a9f7.

    The point of doc/*samples* is they are static files, not
    dynamic. We shouldn't be doing substitution here, this
    breaks all kinds of things, including the doc target.

    Change-Id: Iaaf9fa0096ab62e6d3efbe018d8d4853a2ff8cda
    Closes-Bug: #1553634

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/nova 13.0.0.0rc1

This issue was fixed in the openstack/nova 13.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Rahul U Nair (<email address hidden>) on branch: master
Review: https://review.openstack.org/289074

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.