terminate Ironic instance update resources for all nodes

[Vasyl Saienko]

Node termination [0] calls update_available_resources [1] for all nodes. With huge number of instances it leads to super slow operations.

[0] https://github.com/openstack/ironic/blob/master/ironic/nova/compute/manager.py#L90
[1] https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6375

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/287498

[Matt Riedemann (mriedem)]

This is not a nova bug. Honestly, I didn't know ironic even extended the nova compute manager like this.

[Vasyl Saienko (vsaienko)]

@Matt, at the moment Nova doesn't allow to update resources per single server. Ironic extends existing nova compute manager,
please have look [0]. It calls periodic task from nova to update resources for all servers when deleting single instance.

I agree it is not a bug in Nova, it is missed functionality rather.

[0] https://github.com/openstack/ironic/blob/master/ironic/nova/compute/manager.py

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/287485
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2005b47c92edb41b08ec401ecdbfe816cab13afb
Submitter: Jenkins
Branch: master

commit 2005b47c92edb41b08ec401ecdbfe816cab13afb
Author: vsaienko <email address hidden>
Date: Thu Mar 3 00:44:35 2016 +0200

    Allow to update resource per single node.

    At the moment during Ironic instance termination resources are updated
    for all nodes. As result with high numner of nodes, removing N instances
    initiates N x M requests, where M is the total number of nodes.
    This commit allows to update resources per specific node only.

    Co-Authored-By: Yuriy Zveryanskyy (<email address hidden>)
    Related-Bug: #1552446
    Change-Id: Iffad4a6ab1aaa5fea591c19f6d330dc861c5675d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/287498
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=16d8819891c4bef58760c62c30aa2b68868087b9
Submitter: Jenkins
Branch: master

commit 16d8819891c4bef58760c62c30aa2b68868087b9
Author: vsaienko <email address hidden>
Date: Thu Mar 3 01:07:33 2016 +0200

    Update resources only for specific node during deletion.

    At the moment during Nova instance termination resources are
    updated for all Ironic nodes. As result with high number of nodes,
    removing N instances initiates N x M requests, where M is the total
    number of nodes. This commit allows to update resources per specific
    node on termination.

    Depends-On: Iffad4a6ab1aaa5fea591c19f6d330dc861c5675d

    Change-Id: Ib54741c8564e18f23c4f50bed190dfc66db7ba76
    Closes-Bug: #1552446

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/ironic 6.0.0 release.