The limit of injected file conetent length is incorrect

Bug #1550671 reported by Zhenyu Zheng
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Medium
Unassigned

Bug Description

According to http://developer.openstack.org/api-ref-compute-v2.1.html#createServer , the perameter personality
has limits about path length and content length. And it is pointed out that the content should be base64 encoded
string and the content length limit is the limit of base64 decoded raw data, not the base64 encoded data.

But in the current implementation:
  https://github.com/openstack/nova/blob/master/nova/compute/api.py#L266-L277
we are checking the base64 encoded data.

That is, for example, the quota limit for content length is 256, and user provided a file with the length of 256,
exception.OnsetFileContentLimitExceeded error will rasie as after base64 encoding, the file length will grow.

Tags: api
Changed in nova:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
Changed in nova:
status: New → In Progress
Changed in nova:
status: In Progress → Confirmed
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Zhenyu Zheng (<email address hidden>) on branch: master
Review: https://review.openstack.org/285649

Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Based on Alex Xu's comment in [1] it looks like that this bug report is invalid. If you disagree, reopen the report and add your reasoning.

References:
[1] https://review.openstack.org/#/c/285649/

tags: added: api
Changed in nova:
status: In Progress → Invalid
assignee: Zhenyu Zheng (zhengzhenyu) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Alex Xu informed me that this report is still valid and got discussed in the nova-api meeting [1]. That's why I'm setting the status to "confirmed".

[1] http://eavesdrop.openstack.org/meetings/nova_api/2016/nova_api.2016-03-08-12.00.log.html

Changed in nova:
status: Invalid → Confirmed
importance: Undecided → Medium
Gage Hugo (gagehugo)
Changed in nova:
assignee: nobody → Gage Hugo (gagehugo)
Gage Hugo (gagehugo)
Changed in nova:
assignee: Gage Hugo (gagehugo) → nobody
kevin shen (kevin.shen)
Changed in nova:
assignee: nobody → kevin shen (kevin.shen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317865

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
kevin shen (kevin.shen) wrote :

fix the docs, not the code, As discussion in the nova-api meeting [1]. That's why I'm setting the status to "invalid".

[1] http://eavesdrop.openstack.org/meetings/nova_api/2016/nova_api.2016-03-08-12.00.log.html

Changed in nova:
assignee: kevin shen (kevin.shen) → nobody
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by kevin shen (<email address hidden>) on branch: master
Review: https://review.openstack.org/317865
Reason: fix the docs, not the code, As discussion in the nova-api meeting [1].

[1] http://eavesdrop.openstack.org/meetings/nova_api/2016/nova_api.2016-03-08-12.00.log.html

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.