Cells v1 is borked for live-migrate and evacuate

Bug #1550018 reported by Sylvain Bauza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Sylvain Bauza

Bug Description

So, we recently added a new feature for passing a RequestSpec object from the API down to the conductor.
Unfortunately, the CI (and the bug reporter who was the jerk who wrote the code) missed that Cells V1 provides a Proxy for the ComputeTaskAPI calls we do.
That means that the signature between ComputeTaskAPI methods and (RPC) CellsAPI needs to be the same for live-migrate and evacuate.

Unshelve was also modified, but Cells V1 has a different behaviour (not calling ComputeTaskAPI) so we're good.

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/284959
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9ab6840af64d6af58baf51040afe86a3324221e5
Submitter: Jenkins
Branch: master

commit 9ab6840af64d6af58baf51040afe86a3324221e5
Author: Sylvain Bauza <email address hidden>
Date: Thu Feb 25 22:57:28 2016 +0100

    Fix Cells RPC API by accepting a RequestSpec arg

    Since cells v1 adds a proxy to a call to ComputeTaskAPI for live_migrate
    and rebuild_instance, we need to augment the Cells RPC API to accept
    the request_spec argument for both methods.

    That said, since cells v1 is quite feature-freeze, it's okay to not pass
    the RequestSpec down to the pipe because the cell conductor will then
    act as if the instance was not having a Spec object, which is a compat
    behaviour we want to keep for a very long time.

    Closes-Bug: #1550018

    Change-Id: I1c2aaedfc83e4e97f53c9c504e4585b1f0510d4b

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/nova 13.0.0.0b3

This issue was fixed in the openstack/nova 13.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.