Ironic vif_port_id mismatch with neutron port id if specified multi networks

[Zhenguo Niu]

when booting an ironic instance with multi networks, we create the network resources with the macs from ironic node ports, and then set the neutron port id back to ironic port's extra/vif_port_id, but the current logic will lead the vif-pif ids pair mismatch.

code:

for vif, pif in zip(network_info, ports):
  port_id = six.text_type(vif['id'])
  patch = [{'op': 'add',
       'path': '/extra/vif_port_id',
       'value': port_id}]
  self.ironicclient.call("port.update", pif.uuid, patch)

we should check whether the mac addresses match between vif and pif before setting the 'vif_port_id'.

[Zhenguo Niu (niu-zglinux)]

Add Ironic as a affected project to aware ironic guys, this should be fixed in nova side.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284025

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284025
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e147a63cb396ebaadd7c841a305cf3a52be1d373
Submitter: Jenkins
Branch: master

commit e147a63cb396ebaadd7c841a305cf3a52be1d373
Author: Zhenguo Niu <email address hidden>
Date: Wed Feb 24 17:14:59 2016 +0800

    [Ironic]Match vif-pif mac address before setting 'vif_port_id'

    When booting an ironic instance with multi networks, the ironic port
    'vif_port_id' may mismatch with the corresponding neutron port.

    Closes-Bug: #1549068
    Co-Authored-By: Sivaramakrishna Garimella (<email address hidden>)

    Change-Id: Id5f033136283987eef8de4ce2f6be256e48cdbf8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/290285

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290285
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=21141158f7060b8c279a44edfb1aff397b07683b
Submitter: Jenkins
Branch: stable/liberty

commit 21141158f7060b8c279a44edfb1aff397b07683b
Author: Zhenguo Niu <email address hidden>
Date: Wed Feb 24 17:14:59 2016 +0800

    [Ironic]Match vif-pif mac address before setting 'vif_port_id'

    When booting an ironic instance with multi networks, the ironic port
    'vif_port_id' may mismatch with the corresponding neutron port.

    Closes-Bug: #1549068
    Co-Authored-By: Sivaramakrishna Garimella (<email address hidden>)

    Change-Id: Id5f033136283987eef8de4ce2f6be256e48cdbf8
    (cherry picked from commit e147a63cb396ebaadd7c841a305cf3a52be1d373)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0rc1 release candidate.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 12.0.3 release.