pycryptodome breaks nova/barbican/glance/kite

[Davanum Srinivas (DIMS)]

pysaml2===4.0.3 drags in pycryptodome===3.4 which breaks Nova in the both unit tests and grenade.

nova.tests.unit.test_crypto.KeyPairTest.test_generate_key_pair_1024_bits
------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "nova/tests/unit/test_crypto.py", line 352, in test_generate_key_pair_1024_bits
        (private_key, public_key, fingerprint) = crypto.generate_key_pair(bits)
      File "nova/crypto.py", line 165, in generate_key_pair
        key = paramiko.RSAKey.generate(bits)
      File "/Users/dims/openstack/openstack/nova/.tox/py27/lib/python2.7/site-packages/paramiko/rsakey.py", line 146, in generate
        rsa = RSA.generate(bits, os.urandom, progress_func)
      File "/Users/dims/openstack/openstack/nova/.tox/py27/lib/python2.7/site-packages/Crypto/PublicKey/RSA.py", line 436, in generate
        if e % 2 == 0 or e < 3:
    TypeError: unsupported operand type(s) for %: 'NoneType' and 'int'

[Davanum Srinivas (DIMS) (dims-v)]

It's easy to simulate this : https://review.openstack.org/#/c/279897/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279909

[Davanum Srinivas (DIMS) (dims-v)]

Here's the evidence:
Barbican - https://review.openstack.org/#/c/279977/
Glance - https://review.openstack.org/#/c/279979/
Kite - https://review.openstack.org/#/c/279984/
Kite client - https://review.openstack.org/#/c/279985/

[Steve Martinelli (stevemar)]

is capping pysaml2 not an option?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279909
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fd0f4f69b21cbd20c0eb0e2f8f4506061f4a211
Submitter: Jenkins
Branch: master

commit 1fd0f4f69b21cbd20c0eb0e2f8f4506061f4a211
Author: Davanum Srinivas <email address hidden>
Date: Sat Feb 13 21:22:54 2016 -0500

    Tolerate installation of pycryptodome

    Newer versions of pysaml2 uses pycryptodome, so if by
    accident if this library gets installed, Nova breaks.

    paramiko folks are working on this:
    https://github.com/paramiko/paramiko/issues/637

    In the meanwhile, we should tolerate if either pycrypto
    or pycryptodome is installed.

    Closes-Bug: #1545370
    Change-Id: If88beeb3983705621fe736995939ac20b2daf1f3

[Nikhil Komawar (nikhil-komawar)]

related info http://markmail.org/message/hcytuqadscggayft

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280008
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=b5ffb569e0687b0016ea962348d8454c1517dde4
Submitter: Jenkins
Branch: master

commit b5ffb569e0687b0016ea962348d8454c1517dde4
Author: Davanum Srinivas <email address hidden>
Date: Sun Feb 14 12:44:39 2016 -0500

    Tolerate installation of pycryptodome

    Newer versions of pysaml2 uses pycryptodome, so if by
    accident if this library gets installed, Glance breaks.

    paramiko folks are working on this:
    https://github.com/paramiko/paramiko/issues/637

    In the meanwhile, we should tolerate if either pycrypto
    or pycryptodome is installed.

    Closes-Bug: #1545370
    Change-Id: I8969382b380aa843a0826eded4b694251dd27922

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/glance 12.0.0.0b3 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.0.0.0b3 development milestone.