nova.tests.functional.notification_sample_tests.test_service_update race fails in the gate

[Matt Riedemann]

http://logs.openstack.org/88/251588/35/check/gate-nova-tox-functional/f9f6ff5/console.html#_2016-01-29_10_16_11_248

2016-01-29 10:16:11.248 | Captured traceback:
2016-01-29 10:16:11.248 | ~~~~~~~~~~~~~~~~~~~
2016-01-29 10:16:11.248 | Traceback (most recent call last):
2016-01-29 10:16:11.248 | File "nova/tests/functional/notification_sample_tests/test_service_update.py", line 65, in test_service_force_down
2016-01-29 10:16:11.248 | 'disabled_reason': 'test2'})
2016-01-29 10:16:11.248 | File "nova/tests/functional/notification_sample_tests/notification_sample_base.py", line 92, in _verify_notification
2016-01-29 10:16:11.248 | self.assertJsonEqual(sample_obj, notification)
2016-01-29 10:16:11.249 | File "nova/test.py", line 343, in assertJsonEqual
2016-01-29 10:16:11.249 | inner_mismatch, verbose=True)
2016-01-29 10:16:11.249 | testtools.matchers._impl.MismatchError: Match failed. Matchee: {'publisher_id': u'nova-compute:host1', 'event_type': u'service.update', 'priority': 'INFO', 'payload': {'nova_object.namespace': 'nova', 'nova_object.name': 'ServiceStatusPayload', 'nova_object.data': {'report_count': 1, 'disabled_reason': u'test2', 'topic': u'compute', 'forced_down': True, 'host': u'host1', 'disabled': True, 'binary': u'nova-compute', 'last_seen_up': '2012-10-29T13:42:05Z', 'version': 6}, 'nova_object.version': '1.0'}}
2016-01-29 10:16:11.249 | Matcher: {u'publisher_id': u'nova-compute:host1', u'payload': {u'nova_object.namespace': u'nova', u'nova_object.data': {u'report_count': 1, u'disabled_reason': 'test2', u'disabled': True, u'forced_down': True, u'host': u'host1', u'topic': u'compute', u'binary': u'nova-compute', u'last_seen_up': u'2012-10-29T13:42:05Z', u'version': 5}, u'nova_object.version': u'1.0', u'nova_object.name': u'ServiceStatusPayload'}, u'priority': u'INFO', u'event_type': u'service.update'}
2016-01-29 10:16:11.249 | Difference: 5 != 6

Probably introduced with this change:

https://github.com/openstack/nova/commit/1c4414a264ce034318f3283e7cc827084b300bde

[Balazs Gibizer (balazs-gibizer)]

This is not a race the patch that is failed the test bump the service.version [1] but did not update the service status sample [2]

[1] https://review.openstack.org/#/c/251588/35/nova/objects/service.py
[2] https://github.com/openstack/nova/blob/master/doc/notification_samples/service-update.json#L16

[Matt Riedemann (mriedem)]

This is a problem in https://review.openstack.org/#/c/251588/ because it changed the service version but failed in the gate b/c the test change merged first so https://review.openstack.org/#/c/251588/ got kicked out.