Activity log for bug #1539342

Date Who What changed Old value New value Message
2016-01-29 02:09:00 Zhenyu Zheng bug added bug
2016-01-29 02:09:07 Zhenyu Zheng nova: assignee Zhenyu Zheng (zhengzhenyu)
2016-01-29 02:12:54 Zhenyu Zheng description In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it is actually a dict: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198 We have logic here : https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491 but we directly pass it down to driver here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514 and it has not been handled in libvirt driver: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412 This will cause AttributeError. In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it can also be a dict: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198 We have logic here : https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491 but we directly pass it down to driver here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514 and it has not been handled in libvirt driver: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412 This will cause AttributeError.
2016-01-29 02:33:25 Zhenyu Zheng description In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it can also be a dict: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198 We have logic here : https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491 but we directly pass it down to driver here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514 and it has not been handled in libvirt driver: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412 This will cause AttributeError. In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it is actually a dict: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198 and https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5509-L5514 We should not transform object to dict in the above code, instead, we should transform dict to object. We have logic here : https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491 but we directly pass it down to driver here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514 and it has not been handled in libvirt driver: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412 This will cause AttributeError.
2016-02-09 17:55:46 Markus Zoeller (markus_z) tags live-migration
2016-02-09 18:03:27 Matt Riedemann tags live-migration libvirt live-migration unified-objects
2016-02-09 18:18:52 Matt Riedemann nova: status New Incomplete
2016-02-27 01:48:09 Zhenyu Zheng nova: status Incomplete Invalid