VMware: unable to boot an instance

[Gary Kotton]

The commit https://github.com/openstack/nova/commit/fbe31e461ac3f16edb795993558a2314b4c16b52 broke the driver

2016-01-17 02:44:57.103 ERROR nova.compute.manager [req-eecba3d3-7745-42c4-92f1-f20c6c208bc8 tempest-AggregatesAdminTestJSON-1988995251 tempest-AggregatesAdminTestJSON-1542172103] [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] Instance failed to spawn
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] Traceback (most recent call last):
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] File "/opt/stack/nova/nova/compute/manager.py", line 2184, in _build_resources
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] yield resources
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] File "/opt/stack/nova/nova/compute/manager.py", line 2030, in _build_and_run_instance
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] block_device_info=block_device_info)
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 382, in spawn
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] image_meta = objects.ImageMeta.from_dict(image_meta)
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] File "/opt/stack/nova/nova/objects/image_meta.py", line 97, in from_dict
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] image_meta.get("properties", {}))
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78] AttributeError: 'ImageMeta' object has no attribute 'get'
2016-01-17 02:44:57.103 3120 ERROR nova.compute.manager [instance: 10a7107a-01c8-4691-8a5a-e306451d6d78]

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/270867
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7d5e9e100fcebe280b6c37acffa9ad341cb21486
Submitter: Jenkins
Branch: master

commit 7d5e9e100fcebe280b6c37acffa9ad341cb21486
Author: Gary Kotton <email address hidden>
Date: Thu Jan 21 07:35:34 2016 -0800

    VMware: no longer convert image meta from dict to object

    The image meta is passed from the compute layer as a object so
    we no longer need to do the conversion. This was done in
    commit fbe31e461ac3f16edb795993558a2314b4c16b52

    Closes-bug: #1536718

    Change-Id: I49024563adb27a890f668f6b8a1b219d05e795e1