rollback on destination after failed live migration is not called always

[Shyama]

1. Live migrate instance from host A to B
2. The live migration fails and _rollback_live_migration is called. Here if the remove_volume_connection throw an error the rollback_live_migration_at_destination is not called.
3. This could leave resources not cleaned up on the destination.

https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5489 any exception from the remove_volume_connection should be handled and the rollback on destination should be called.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/270093

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/270093
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

This is an older bug, please confirm (and put in the Confirmed State) if this is still known.

[Launchpad Janitor (janitor)]

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]