rollback on destination after failed live migration is not called always

Bug #1535643 reported by Shyama on 2016-01-19

This bug report will be marked for expiration in 32 days if no further activity occurs. (find out why)

10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Unassigned

Bug Description

1. Live migrate instance from host A to B
2. The live migration fails and _rollback_live_migration is called. Here if the remove_volume_connection throw an error the rollback_live_migration_at_destination is not called.
3. This could leave resources not cleaned up on the destination.

https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5489 any exception from the remove_volume_connection should be handled and the rollback on destination should be called.

Wenzhi Yu (yuywz) on 2016-01-20
Changed in nova:
assignee: nobody → Wen Zhi Yu (yuywz)

Fix proposed to branch: master
Review: https://review.openstack.org/270093

Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Wenzhi Yu (yuywz) → Pawel Koniszewski (pawel-koniszewski)
Changed in nova:
assignee: Pawel Koniszewski (pawel-koniszewski) → Wenzhi Yu (yuywz)
tags: added: live-migration
Changed in nova:
importance: Undecided → Low

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/270093
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Matt Riedemann (mriedem) on 2017-06-15
Changed in nova:
assignee: Wenzhi Yu (yuywz) → nobody
status: In Progress → New
Sean Dague (sdague) wrote :

This is an older bug, please confirm (and put in the Confirmed State) if this is still known.

Changed in nova:
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers