illustration of 'notify_on_state_change' are different from implementation

Bug #1535254 reported by wuhao on 2016-01-18
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Undecided
Unassigned

Bug Description

I'm using liberty to get notifications from nova. And I found a problem with 'notify_on_state_change'.

In the configuration doc, 'notify_on_state_change' means that "If set, send compute.instance.update notifications on instance state changes." Valid values are None, 'vm_state' and 'vm_and_task_state'. However, in current implementation, if it's set to 'vm_state', compute.instance.update notifications will be sent for all the state changes and it will be a special state change notification when the vm state changes. So as to 'vm_and_task_state'.

wuhao (wuhao) on 2016-01-18
Changed in nova:
assignee: nobody → wuhao (wuhao)
Augustina Ragwitz (auggy) wrote :

Please provide a link the configuration documentation you used so we can verify and possibly reassign the bug to the openstack-manuals team.

Changed in nova:
status: New → Incomplete
wuhao (wuhao) wrote :

The doc is http://docs.openstack.org/liberty/config-reference/content/list-of-compute-config-options.html
and also you can get the illustraion in https://github.com/openstack/nova/blob/master/nova/notifications.py#L44 which is different from actual implementation.

Currently, if 'notify_on_state_change' is set to 'vm_state' or 'vm_and_task_state', all the changes will cause a compute.instance.update notification. I think we'd better introduce another valid value 'all_state' to get all the compute.instance.update notifications. And if 'vm_and_task_state' is set, we only send update notifications when vm state or task state have been changed. The same with 'vm_state'.

Fix proposed to branch: master
Review: https://review.openstack.org/269720

Changed in nova:
status: Incomplete → In Progress

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/269720
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

Changed in nova:
status: In Progress → Confirmed
assignee: wuhao (wuhao) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers