AttributeError: 'LibvirtLiveMigrateData' object has no attribute 'get'

[Matt Riedemann]

Seen here:

http://logs.openstack.org/88/251588/26/check/gate-tempest-dsvm-multinode-full/748c334/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-01-15_18_55_19_856

2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] Traceback (most recent call last):
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 6213, in _live_migration
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] dom, finish_event, disk_paths)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 6134, in _live_migration_monitor
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] migrate_data)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/exception.py", line 110, in wrapped
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] payload)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 204, in __exit__
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] six.reraise(self.type_, self.value, self.tb)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/exception.py", line 89, in wrapped
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] return f(self, context, *args, **kw)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/compute/manager.py", line 385, in decorated_function
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] kwargs['instance'], e, sys.exc_info())
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 204, in __exit__
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] six.reraise(self.type_, self.value, self.tb)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/compute/manager.py", line 373, in decorated_function
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] return function(self, context, *args, **kwargs)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/compute/manager.py", line 5371, in _post_live_migration
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] destroy_vifs=destroy_vifs)
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 961, in cleanup
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] migrate_data and migrate_data.get('is_shared_block_storage',
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665] AttributeError: 'LibvirtLiveMigrateData' object has no attribute 'get'
2016-01-15 18:55:19.856 9643 ERROR nova.virt.libvirt.driver [instance: dc5a3e3c-f844-4947-a0b6-c162141af665]

It's swallowed by the libvirt driver so that's why it's not failing jobs.

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AttributeError%3A%20'LibvirtLiveMigrateData'%20object%20has%20no%20attribute%20'get'%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22%20AND%20voting%3A%5C%221%5C%22&from=7d

Introduced here I think: https://review.openstack.org/#/c/248211/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/268352

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268352
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6d9273b25f054414d4271030c09b4353424fed21
Submitter: Jenkins
Branch: master

commit 6d9273b25f054414d4271030c09b4353424fed21
Author: Matt Riedemann <email address hidden>
Date: Fri Jan 15 14:27:28 2016 -0800

    libvirt: handle migrate_data as object in cleanup method

    As of 69e01758076d0e89eddfe6945c8c7e423c862a49, the
    migrate_data parameter is a LibvirtLiveMigrateData object
    and doesn't have dict-compat so we have to handle it like an
    object.

    Also adds a unit test for this case which didn't exist before
    which is probably why it wasn't caught in the previous change.

    Change-Id: I5a676334d0082373b5c1895f060283cc942b2d40
    Closes-Bug: #1534837

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b2 development milestone.