There should be a DB API test that ensures no new tables have soft-delete columns
Bug #1533859 reported by
Matt Riedemann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Diana Clarke |
Bug Description
In mitaka we approved a spec to no longer have the SoftDeleteMixin in the data model so new tables don't implicitly inherit from that and get the deleted and deleted_at columns:
http://
We don't have anything enforcing that policy though, except code review, which has failed a few times.
We should have a db api unit test which basically has a whitelist of which tables already have those columns and then we check the models against that, and if any new tables are introduced in the model which have the deleted or deleted_at columns, they'd fail the test.
Changed in nova: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: low-hanging-fruit |
Changed in nova: | |
assignee: | nobody → Chuck Carmack (chuckcarmack75) |
Changed in nova: | |
assignee: | nobody → Diana Clarke (diana-clarke) |
To post a comment you must log in.
@Chuck: Do you plan on working on this still? If not, I'd like to take this. Cheers