InstanceList.fill_faults() method must have 'context' argument

[Pavel Kholkin]

'context' is not passed to InstanceList.fill_faults() method.

Previously in sqlalchemy.api level 'instance_fault_get_by_instance_uuids' method doesn't properly used 'context' because 'model_query' inside doesn't really use context attributes. After switching to enginefacade this problem was found because we always need real 'context' to store 'session' in it.

The 'context' can be None e.g. when we create new empty InstanceList object by 'instance_list = objects.InstanceList()' and then call 'instance_list.fill_faults()' (https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L404-L407)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261979
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=86963e60bea60f45d7d730442f6b447f58c3f275
Submitter: Jenkins
Branch: master

commit 86963e60bea60f45d7d730442f6b447f58c3f275
Author: Pavel Kholkin <email address hidden>
Date: Mon Dec 28 15:07:42 2015 +0300

    enginefacade: 'ec2_instance' and 'instance_fault'

    Use enginefacade in 'ec2_instance' and 'instance_fault' sections.

    Implements: blueprint new-oslodb-enginefacade

    Closes-Bug: #1533684

    Co-Authored-By: Sergey Nikitin <email address hidden>

    Change-Id: I39406c41f8674fff538b15d8e23b4e9258cf5fc3

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.0.0.0b3 development milestone.