Nova is leaking libvirt internal ids on some Instance Not Found errors

[Sean Dague]

Nova from master in the gate.

libvirt is incorrectly using InstanceNotFound as an internal exception, but handing it libvirt internal ids instead of an openstack uuid or ec2id. This means it jumps up through the stack and back to the user, giving errors over http like Instance instance-000000a not found. This is both an information leak, and useless bit of information for the user to figure out what's going on.

libvirt should use an internal exception instead.

[Matt Riedemann (mriedem)]

Seen here:

http://logs.openstack.org/54/232554/17/check/gate-grenade-dsvm-multinode/dcd1e94/logs/old/screen-n-api.txt.gz?level=INFO#_2015-12-03_09_47_51_258

https://github.com/openstack/nova/blob/89dd62aabf62175724e0e05765c9759cd9160263/nova/virt/libvirt/host.py#L654

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22HTTP%20exception%20thrown:%20Instance%20instance-%5C%22%20AND%20message:%5C%22could%20not%20be%20found.%5C%22%20AND%20tags:%5C%22screen-n-api.txt%5C%22

This just started happening in the last 24 hours.

[Matt Riedemann (mriedem)]

Actually it's been around, the code has been there since at least kilo, so it's just intermittent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261417

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yusuke Ide (<email address hidden>) on branch: master
Review: https://review.openstack.org/261417

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290706

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/290706
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290706
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f26569649b5785e18581143f30cd5d44a77c1bf
Submitter: Jenkins
Branch: master

commit 0f26569649b5785e18581143f30cd5d44a77c1bf
Author: Stephen Finucane <email address hidden>
Date: Tue Dec 13 13:47:38 2016 +0000

    libvirt: Flatten 'get_domain' function

    Recent changes to the code mean the function 'get_domain' is the sole
    caller of '_get_domain_by_name'. This structure is unnecessarily bloated
    and prevents us from raising valid InstanceNotFound exceptions
    containing Instance.uuid values. Fold the latter functions into the
    former, shedding this excess weight and partially resolving the bug.

    Change-Id: I43d608a629b3dba204264f1db97fb35b205aee85
    Closes-Bug: #1522454

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b3 development milestone.