nova unit tests failing with infinite recursion with oslo.versionedobjects 0.13.0

[Matt Riedemann]

Seen here:

http://logs.openstack.org/20/243320/4/gate/gate-nova-python27/37b1b32/console.html

Just started on 11/16 with the o.vo 0.13.0 release.

Lots of this:

2015-11-16 21:00:40.347 | result = getattr(cls, objmethod)(context, *args, **kwargs)
2015-11-16 21:00:40.347 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/base.py", line 173, in wrapper
2015-11-16 21:00:40.348 | args, kwargs)
2015-11-16 21:00:40.348 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fixture.py", line 106, in object_class_action_versions
2015-11-16 21:00:40.348 | result = getattr(cls, objmethod)(context, *args, **kwargs)
2015-11-16 21:00:40.348 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/base.py", line 173, in wrapper
2015-11-16 21:00:40.348 | args, kwargs)
2015-11-16 21:00:40.348 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fixture.py", line 106, in object_class_action_versions
2015-11-16 21:00:40.348 | result = getattr(cls, objmethod)(context, *args, **kwargs)
2015-11-16 21:00:40.348 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/base.py", line 173, in wrapper
2015-11-16 21:00:40.348 | args, kwargs)
2015-11-16 21:00:40.348 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fixture.py", line 106, in object_class_action_versions
2015-11-16 21:00:40.349 | result = getattr(cls, objmethod)(context, *args, **kwargs)
2015-11-16 21:00:40.349 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/base.py", line 173, in wrapper
2015-11-16 21:00:40.349 | args, kwargs)

[Matt Riedemann (mriedem)]

g-r block on 0.13.0: https://review.openstack.org/#/c/246002/

[Matt Riedemann (mriedem)]

This is the breaking change: https://review.openstack.org/#/c/224862/

[Matt Riedemann (mriedem)]

Actually that was a red herring, it's this that's failing: https://review.openstack.org/#/c/224861/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246011

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246013

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/246022

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/246011
Reason: Hoping https://review.openstack.org/#/c/246013/ will fix everything.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246013
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b3fbfb087998633ea66db223c0f7c201f69e49a
Submitter: Jenkins
Branch: master

commit 1b3fbfb087998633ea66db223c0f7c201f69e49a
Author: Dan Smith <email address hidden>
Date: Mon Nov 16 14:46:16 2015 -0800

    Fix Nova's indirection fixture override

    This mirrors the indirection fixture override that we have for
    object_class_action() while we transition fully to the base
    VersionedObjectRegistry. This prevents us from breaking with current
    oslo.versionedobjects.

    This also caused a few other tests to get run with manifest calls,
    which needed to be converted to continue to work.

    Change-Id: I2aaa42784b2cc5c6898a3fac0c951dd57dd4f4c6
    Closes-Bug: #1516805

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246022
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0ff44c9d50bbe01e23bc9699e1aaab3ddfaaa0eb
Submitter: Jenkins
Branch: stable/liberty

commit 0ff44c9d50bbe01e23bc9699e1aaab3ddfaaa0eb
Author: Dan Smith <email address hidden>
Date: Mon Nov 16 14:46:16 2015 -0800

    Fix Nova's indirection fixture override

    This mirrors the indirection fixture override that we have for
    object_class_action() while we transition fully to the base
    VersionedObjectRegistry. This prevents us from breaking with current
    oslo.versionedobjects.

    This also caused a few other tests to get run with manifest calls,
    which needed to be converted to continue to work. Also, because
    liberty still has both InstanceV1 and InstanceV2, this tickled another
    case where we need to use the instance base class for a mox.IsA() check.

    Change-Id: I2aaa42784b2cc5c6898a3fac0c951dd57dd4f4c6
    Closes-Bug: #1516805
    (cherry picked from commit 1b3fbfb087998633ea66db223c0f7c201f69e49a)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 12.0.1 release.