Scheduler driver should use Service object

Bug #1514863 reported by Sylvain Bauza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Diana Clarke

Bug Description

There is still one place where the Scheduler does direct DB access instead of using the oslo.versionedobjects layer

https://github.com/openstack/nova/blob/af2d6c9576b1ac5f3b3768870bb15d9b5cf1610b/nova/scheduler/driver.py#L54

Instead of calling db.service_get_all_by_topic(), it should call objects.ServiceList.get_by_topic()

Changed in nova:
assignee: nobody → shravya Gaddam (shravya-g90)
Changed in nova:
assignee: shravya Gaddam (shravya-g90) → Diana Clarke (diana-clarke)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243694

Changed in nova:
status: Triaged → In Progress
Revision history for this message
Diana Clarke (diana-clarke) wrote :

@shravya-g90: It looks like we both grabbed this bug an hour ago. I didn't notice you were also working on it until I refreshed by browser just now. My apologies.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/243694
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=66794097f0905daaa475666f3cf46cefd5e86253
Submitter: Jenkins
Branch: master

commit 66794097f0905daaa475666f3cf46cefd5e86253
Author: Diana Clarke <email address hidden>
Date: Mon Nov 16 11:37:18 2015 -0500

    Use ServiceList object rather than direct db call

    The scheduler driver should use the ServiceList object rather than a
    direct db call to get all services by topic.

    Change-Id: I7fb8a52e8283aa6d47b91b49bbcf76495b289946
    Closes-Bug: #1514863

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/nova 13.0.0.0b1

This issue was fixed in the openstack/nova 13.0.0.0b1 development milestone.

Changed in nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.