Ironic virt driver in Nova calls destroy unnecessarily if spawn fails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Shraddha Pandhe |
Bug Description
To give some context, calling destroy [5] was added as a bug fix [1]. It was required back then because, Nova compute was not calling destroy on catching the exception [2]. But now, Nova compute catches all exceptions that happen during spawn and calls destroy (_shutdown_
Since Nova compute is already taking care of destroying the instance before rescheduling, we shouldn't have to call destroy separately in the driver. I confirmed in logs that destroy gets called twice if there is any failure during _wait_for_active() [4] or timeout happens [5]
[1] https:/
[2] https:/
[3] https:/
[4] https:/
[5] https:/
affects: | nova-hyper → nova |
Changed in nova: | |
assignee: | nobody → Shraddha Pandhe (shraddha-pandhe) |
Changed in nova: | |
importance: | Undecided → Low |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/240357
Review: https:/