aggregate instance extra specs filter incorrectly filter out qualified host

Bug #1504196 reported by Baodong (Robert) Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Unassigned

Bug Description

With the below extra_specs in a flavor:
  extra_specs | {"cpu_arch": "x86_64", "aggregate_instance_extra_specs:bm": "true"} |

The filter doesn't qualify a host that satisfies "aggregate_instance_extra_specs:bm": "true". This is because "cpu_arch": "x86_64" doesn't match any aggregates since "cpu_arch" is not defined in aggregates' metadata. This is wrong since the filter should only look at keys with initial scope being "aggregate_instance_extra_specs", and should not look at the key "cpu_arch" at all

Changed in nova:
assignee: nobody → Baodong (Robert) Li (baoli)
tags: added: scheduler
Changed in nova:
importance: Undecided → Low
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

@Baodong (Robert) Li:

Since you are set as assignee and this seems to be a valid bug, I switch
the status of it to "In Progress". Thanks for taking the effort to solve
this. If your plans change, just remove yourself as assignee and set the
status to the previous one.

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233095

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/233095

Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Cleanup
=======

There are no open reviews for this bug report since more than 2 weeks.
To signal that to other contributors which might provide patches for
this bug, I switch the status from "In Progress" to "Confirmed" and
remove the assignee.
Feel free to add yourself as assignee and to push a review for it.

Changed in nova:
status: In Progress → Confirmed
assignee: Baodong (Robert) Li (baoli) → nobody
Revision history for this message
Baodong (Robert) Li (baoli) wrote :

Hi Aishwarya, I created a flavor that is associated with a host aggregate.

nova flavor-create bm-flavor auto 131072 836 48
nova flavor-key bm-flavor set cpu_arch=x86_64

nova aggregate-create bm-agg bm-zone
nova aggregate-add-host bm-agg ip6-devstack-41
nova aggregate-set-metadata bm-agg bm=true
nova flavor-key bm-flavor set aggregate_instance_extra_specs:bm=true

Hope it'll help you recreate the bug

aishwarya (bkaishwarya)
Changed in nova:
assignee: nobody → aishwarya (bkaishwarya)
Revision history for this message
aishwarya (bkaishwarya) wrote :

Hi,
I tried to reproduce the bug in openstack mitaka version following the steps as mentioned.
Below is my observation:
By changing "nova flavor-key bm-flavor set cpu_arch=x86_64" to
"nova flavor-key bm-flavor set capabilities:cpu_info:arch=x86_64" we are not getting any error and the host is qualified.

In dashboard ,
we can set the same in dashboard as cpu_arch to x86 in flavors metadata->compute host capabilities-> architecture->x86_64 .

Sean Dague (sdague)
Changed in nova:
assignee: aishwarya (bkaishwarya) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers